Always assume subscriptions will return sub count from current key (#…

…2460)
vercel · Feb 27, 2023 · 3b04acf · 3b04acf
1 parent 2464ed5
commit 3b04acf
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/subscription/index.ts b/subscription/index.ts
@@ -86,14 +86,13 @@ export const subscription = (<Data, Error>(useSWRNext: SWRHook) =>
       return () => {
         // Prevent frequent unsubscribe caused by unmount
         setTimeout(() => {
-          // TODO: Throw error during development if count is undefined.
-          const count = subscriptions.get(subscriptionKey)
-          if (count == null) return
+          // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+          const count = subscriptions.get(subscriptionKey)! - 1
 
-          subscriptions.set(subscriptionKey, count - 1)
+          subscriptions.set(subscriptionKey, count)
 
           // Dispose if it's the last one.
-          if (count === 1) {
+          if (!count) {
             const dispose = disposers.get(subscriptionKey)
             dispose?.()
           }