-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: add $ prefix for non-major keys #1174
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4084724:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also add it to inf
, len
and ctx
in swr-infinite 👍
curious about the reason of designing page key as |
Oh that's a good point, since it already has
That's because if we directly use |
Co-authored-by: Jiachi Liu <inbox@huozhi.im>
Looks good to me, let's also change existing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make symbol rich
Thanks! 🤣
specialize keys for
error
andisValidating
, and some non major keys in swr infinite, to identify them easier later if developers want to play tricks with keys or filter them from cache provider.Resolves #242
e.g.
access all keys
access pending requests