Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fail accessing navigator on Node #1254

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

koba04
Copy link
Collaborator

@koba04 koba04 commented Jul 1, 2021

navigator doesn't exist on the Node environment, so it is required to check if navigator is not undefined.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 1, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 98ec6cc:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration

Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shuding shuding merged commit 9d0fbf4 into vercel:master Jul 1, 2021
@koba04
Copy link
Collaborator Author

koba04 commented Jul 1, 2021

Thank you!

@koba04 koba04 deleted the fix-navigator-on-node branch July 1, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants