Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infinite] Return current data if failed to resolve pages from cache when setting size #1379

Merged
merged 2 commits into from
Aug 25, 2021
Merged

[Infinite] Return current data if failed to resolve pages from cache when setting size #1379

merged 2 commits into from
Aug 25, 2021

Conversation

shuding
Copy link
Member

@shuding shuding commented Aug 24, 2021

Fix #1362.

@shuding shuding requested a review from huozhi as a code owner August 24, 2021 20:51
@shuding shuding mentioned this pull request Aug 24, 2021
Closed
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 24, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5e79cfb:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration

@huozhi
Copy link
Member

huozhi commented Aug 25, 2021

Awesome, this is the right fix! Tested with the sandbox link provided

@huozhi huozhi merged commit 96b49a8 into master Aug 25, 2021
@huozhi huozhi deleted the fix-infinite-fallback branch August 25, 2021 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huozhi huozhi huozhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

infinite (beta): data becomes empty when using setSize and initialData
2 participants
@shuding @huozhi