Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename revalidateWhenStale to revalidateIfStale #1381

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

shuding
Copy link
Member

@shuding shuding commented Aug 25, 2021

Both have the same meaning, but "if" is close to the HTTP cache control naming conventions ("only-if-cached", "stale-if-error").

@shuding shuding requested a review from huozhi as a code owner August 25, 2021 11:12
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 094712f:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration

Copy link
Member

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! "If" sounds better to me since "when" is more implying a moment

@shuding shuding merged commit 0e892f1 into master Aug 25, 2021
@shuding shuding deleted the rename-revalidate-if-stale branch August 25, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants