Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing: use separated constants instead of enum #1425

Merged
merged 4 commits into from Sep 4, 2021
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Sep 1, 2021

Resolves #1420

Checked the bundle size is consistent

@huozhi huozhi requested a review from shuding as a code owner September 1, 2021 16:47
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 1, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dcf8a7e:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration

@shuding shuding merged commit 20c02df into master Sep 4, 2021
@shuding shuding deleted the enum-to-consts branch September 4, 2021 22:22
@shuding
Copy link
Member

shuding commented Sep 4, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type issue with the isolatedModules flag on
2 participants