Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scripts on windows #171

Merged
merged 2 commits into from
Dec 4, 2019
Merged

Scripts on windows #171

merged 2 commits into from
Dec 4, 2019

Conversation

Svish
Copy link
Contributor

@Svish Svish commented Dec 3, 2019

This replaces the ' in package.json scripts with " so that they can also run on Windows.

It also removes an unused import in an example I added in a previous PR.

lfades
lfades approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next.js does this too 👍

@shuding shuding merged commit 66b2988 into vercel:master Dec 4, 2019
@Svish Svish deleted the scripts-on-windows branch December 6, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfades lfades lfades approved these changes

@pacocoursey pacocoursey Awaiting requested review from pacocoursey

@shuding shuding Awaiting requested review from shuding

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Svish @lfades @shuding