chore: remove useless overload #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dd90fe6:
|
shuding
reviewed
May 25, 2022
huozhi
approved these changes
May 25, 2022
|
👍 |
huozhi
pushed a commit
that referenced
this pull request
Jun 6, 2022
huozhi
pushed a commit
that referenced
this pull request
Jun 25, 2022
shuding
added a commit
that referenced
this pull request
Jun 26, 2022
* feat: mutate filter * tweak typing * add test * tweak typings * chore: remove useless overload (#1993) * fix typing * chore: change internalMutate type (#1997) * chore: change internalMutate type * chore: useoverload for internal mutate * store keys in global state * add type truthy key * polish truthy key * dont remove key * add clear test case, fix empty key * store key in cache * use values * fix cache test * pass original argument to the filter * fix types * fix types * fix failed tests; use useSyncExternalStore and memorized selector * move function declaration * fix infinite use cases * fix lint error Co-authored-by: Yixuan Xu <yixuanxu94@outlook.com> Co-authored-by: Shu Ding <g@shud.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.