Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #182 #207

Merged
merged 2 commits into from
Dec 23, 2019
Merged

Fix #182 #207

merged 2 commits into from
Dec 23, 2019

Conversation

promer94
Copy link
Collaborator

@promer94 promer94 commented Dec 18, 2019 •
edited

close #182

shuding
shuding reviewed Dec 18, 2019
View reviewed changes
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot @promer94 for helping this! The code looks great and the tests are amazing. But it has some conflicts with a PR that we just merged, could you fix it? Then I think it's all good!

shuding
shuding reviewed Dec 19, 2019
View reviewed changes
src/use-swr.ts Outdated Show resolved Hide resolved
shuding
shuding approved these changes Dec 23, 2019
View reviewed changes
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @promer94, the code looks great.

@shuding shuding merged commit 915b008 into vercel:master Dec 23, 2019
@promer94 promer94 deleted the dynamic-polling-interval branch January 3, 2020 03:02
@huozhi huozhi mentioned this pull request Jan 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuding shuding shuding approved these changes

@pacocoursey pacocoursey Awaiting requested review from pacocoursey

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic polling interval
2 participants
@promer94 @shuding