skip immediate revalidation when initalData is provided #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addstar34
requested review from
pacocoursey,
shuding and
Timer
as code owners
shuding
approved these changes
Dec 22, 2019
|
@addstar34 do you think this PR could introduce a regression i described in #230 ? |
|
After upgrading, if I set the |
aj-may
added a commit
to aj-may/swr
that referenced
this pull request
May 12, 2020
It appears some time ago the `initialData` configuration was used as a fallback. When vercel#211 was merged, this behavior changed to be used with SSR like in the next.js example in the README. Issue vercel#230 explains this was the expectation. I'm using SSR, so im fine with the new behavior. Since `initialData` is now not quickly revalidated, another issue (vercel#308) has been raised. Since `initialData` is not cached, and the mutate w/ callback grabs the curerent data from the cache, when `initialData` is used, `undefined` is returned. fixes vercel#308
Closed
aj-may
added a commit
to aj-may/swr
that referenced
this pull request
May 22, 2020
It appears some time ago the `initialData` configuration was used as a fallback. When vercel#211 was merged, this behavior changed to be used with SSR like in the next.js example in the README. Issue vercel#230 explains this was the expectation. I'm using SSR, so im fine with the new behavior. Since `initialData` is now not quickly revalidated, another issue (vercel#308) has been raised. Since `initialData` is not cached, and the mutate w/ callback grabs the curerent data from the cache, when `initialData` is used, `undefined` is returned. fixes vercel#308
aj-may
added a commit
to aj-may/swr
that referenced
this pull request
May 29, 2020
It appears some time ago the `initialData` configuration was used as a fallback. When vercel#211 was merged, this behavior changed to be used with SSR like in the next.js example in the README. Issue vercel#230 explains this was the expectation. I'm using SSR, so im fine with the new behavior. Since `initialData` is now not quickly revalidated, another issue (vercel#308) has been raised. Since `initialData` is not cached, and the mutate w/ callback grabs the curerent data from the cache, when `initialData` is used, `undefined` is returned. fixes vercel#308
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #194.
I wasn't sure if this should be set via another option or not but if so let me know and I can update.