Fix a race condition bug #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacocoursey
approved these changes
Feb 14, 2020
shuding
added a commit
that referenced
this pull request
Feb 19, 2020
* Update README.md (#235) * test(typo): fix typo (#244) * fix weakmap key is `null` (#251) * fix race condition and add test (#261) * 0.1.17 * Add regression test for weakmap key is `null` This add a regression test for the fix of #251 Co-authored-by: Shu Ding <ds303077135@gmail.com> Co-authored-by: Darren Jennings <dmjenn02@gmail.com>
shuding
added a commit
that referenced
this pull request
Feb 24, 2020
* Improve mutate function - If no data call trigger against the key - If data is a function call it passing current cached value - Return data or throw error after function * useSWR now returns a bound mutate call with key predefined * Remove trick to make shouldRevalidate true only with local mutation Also update related test to manually pass shouldRevalidate as false * Add mutate to list of returned values from useSWR * Replace trigger with mutate * Add Mutate Based on Current Data example * Add Returned Data from Mutate example * Update Optimistic UI example * Update README.md (#235) * test(typo): fix typo (#244) * fix weakmap key is `null` (#251) * fix race condition and add test (#261) * 0.1.17 * Apply changes * Update src/use-swr.ts * Update src/use-swr.ts * Apply suggestions from code review Co-authored-by: Shu Ding <ds303077135@gmail.com> Co-authored-by: Darren Jennings <dmjenn02@gmail.com>
shuding
added a commit
that referenced
this pull request
Feb 24, 2020
* Add CacheInterface type * Create defautl cache and use it in the code * Add test to custom cache support * Replace custom cache with exposed cache * Fix error in comment * Update README.md (#235) * test(typo): fix typo (#244) * fix weakmap key is `null` (#251) * fix race condition and add test (#261) * 0.1.17 * Move getKeyArgs and getErrorKey to serializeKey in Cache * Make the Map instance in Cache private * Add methods to subscribe to cache updates and get all keys * Apply suggestions from code review Co-Authored-By: Shu Ding <ds303077135@gmail.com> * Don't ignore tests * Cache methods receive keyInterface and serialize it if it's not a string * Don't expose Cache class anymore Co-authored-by: Shu Ding <ds303077135@gmail.com> Co-authored-by: Darren Jennings <dmjenn02@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
await CONCURRENT_PROMISES[key]should be called before deduping. Because there could be this potential bug, saydedupingIntervalis 2s:Which is a race condition, the request fired first got returned last.
(Also added a test for
mutatein this PR)