Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SWRInfiniteMutatorOptions type to export #2954

Merged

Conversation

ludwigbacklund
Copy link
Contributor

@ludwigbacklund ludwigbacklund commented Apr 30, 2024

When using "moduleResolution": "Bundler" in tsconfig.json for a TypeScript project, and implicitly referencing SWRInfiniteMutatorOptions you get this error:

Exported variable '<redacted>' has or is using name 'SWRInfiniteMutatorOptions' from external module "/path/node_modules/swr/dist/infinite/index" but cannot be named.ts(4023)

These errors can be resolved by explicitly exporting these implicitly references types from swr.

Copy link

codesandbox-ci bot commented Apr 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Collaborator

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thank you!

@promer94 promer94 merged commit cc9fc25 into vercel:main May 2, 2024
7 checks passed
@ludwigbacklund ludwigbacklund deleted the export-infinite-mutator-options-type branch May 3, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants