Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a README to every example #79

Merged
merged 5 commits into from Nov 5, 2019
Merged

Add a README to every example #79

merged 5 commits into from Nov 5, 2019

Conversation

sergiodxa
Copy link
Contributor

@sergiodxa sergiodxa commented Nov 5, 2019

The README contains:

  • How to download the examples
  • How to install their dependencies and run it
  • How to deploy it to Now
  • What the examples are about

The structure is based on the Next.js examples README.

- How to download only this examples
- How to install their dependencies and run it
- How to deploy it to Now
- What the examples are about
@shuding
Copy link
Member

shuding commented Nov 5, 2019

Thank you! I think we need to remove "swr": "link:../..", and add swr, react, react-dom into dependencies so they can be standalone projects.

As the benefit, we can add deploy buttons (https://github.com/zeit/now-examples/tree/master/nextjs), live examples (Codesandbox) to these examples in the future!

Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shuding shuding merged commit e9451bc into vercel:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants