Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace useLayoutEffect by useIsomorphicLayoutEffect to avoid ssr warnings #85

Merged
merged 1 commit into from
Nov 6, 2019
Merged

replace useLayoutEffect by useIsomorphicLayoutEffect to avoid ssr warnings #85

merged 1 commit into from
Nov 6, 2019

Conversation

bmvantunes
Copy link
Contributor

shuding
shuding approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@shuding shuding merged commit e5d8ed3 into vercel:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuding shuding shuding approved these changes

@pacocoursey pacocoursey Awaiting requested review from pacocoursey

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Next] StrictMode
2 participants
@bmvantunes @shuding