Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
  • Loading branch information
arlyon and chris-olszewski committed Jan 8, 2024
1 parent cf2111c commit 5b6ba77
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions crates/turborepo-lib/src/engine/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -199,10 +199,10 @@ impl Engine<Built> {

// check if the package for the task has that task in its package.json
let info = package_graph
.workspace_info(&WorkspaceName::Other(task_id.package().to_string()))
.workspace_info(&WorkspaceName::from(task_id.package().to_string()))
.expect("package graph should contain workspace info for task package");

Check failure on line 204 in crates/turborepo-lib/src/engine/mod.rs

View workflow job for this annotation

GitHub Actions / Rust lints

Diff in /root/actions-runner/_work/turbo/turbo/crates/turborepo-lib/src/engine/mod.rs
let package_has_task = info.package_json.scripts.contains_key(task_id.task());
let package_has_task = info.package_json.scripts.get(task_id.task()).map_or(false, |script| !script.is_empty());

let task_is_persistent = self
.task_definitions
Expand Down

0 comments on commit 5b6ba77

Please sign in to comment.