Skip to content

Commit

Permalink
Update TS module resolutions in examples. (#7872)
Browse files Browse the repository at this point in the history
### Description

Updating so we don't use `"moduleResolution": "node"` in examples. It's
outdated!

Closes TURBO-2737
  • Loading branch information
anthonyshew committed Apr 2, 2024
1 parent 35a9bb0 commit 6839aa2
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 8 deletions.
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Expand Up @@ -7,7 +7,7 @@
"isolatedModules": true,
"esModuleInterop": true,
"jsx": "react-jsx",
"moduleResolution": "node",
"moduleResolution": "Bundler",
"resolveJsonModule": true,
"target": "ES2019",
"strict": true,
Expand Down
1 change: 1 addition & 0 deletions examples/with-changesets/apps/docs/package.json
Expand Up @@ -18,6 +18,7 @@
},
"devDependencies": {
"@acme/tsconfig": "workspace:*",
"@next/eslint-plugin-next": "^14.1.1",
"@types/node": "^20.11.24",
"@types/react": "^18.2.61",
"@types/react-dom": "^18.2.19",
Expand Down
2 changes: 1 addition & 1 deletion examples/with-changesets/packages/acme-tsconfig/base.json
Expand Up @@ -9,7 +9,7 @@
"forceConsistentCasingInFileNames": true,
"inlineSources": false,
"isolatedModules": true,
"moduleResolution": "node",
"moduleResolution": "NodeNext",
"noUnusedLocals": false,
"noUnusedParameters": false,
"preserveWatchOutput": true,
Expand Down
Expand Up @@ -10,6 +10,7 @@
"jsx": "preserve",
"lib": ["dom", "dom.iterable", "esnext"],
"module": "esnext",
"moduleResolution": "Bundler",
"noEmit": true,
"resolveJsonModule": true,
"target": "es5"
Expand Down
Expand Up @@ -5,7 +5,7 @@
"compilerOptions": {
"jsx": "react-jsx",
"lib": ["dom", "ES2015"],
"module": "ESNext",
"module": "NodeNext",
"target": "es6"
}
}
9 changes: 6 additions & 3 deletions examples/with-changesets/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 6839aa2

Please sign in to comment.