review comments

.github/workflows/README.md

@@ -0,0 +1,6 @@
+## Rust workflows
+
+### cargo-install
+
+- [taiki-e/install-action](https://github.com/taiki-e/install-action) can only be used when pre built binaries are available.
+- [baptiste0928/cargo-install](https://github.com/baptiste0928/cargo-install) will compile the binary and cache it.

.github/workflows/bench-turbopack-scheduled.yml

@@ -79,7 +79,7 @@ jobs:
 
       - uses: ./.github/actions/setup-rust
         with:
-          shared-key: benchmark-${{ matrix.bench.cache_key }}
+          shared-cache-key: benchmark-${{ matrix.bench.cache_key }}
 
       - name: Clear potentially cached benchmarks
         run: rm -rf target/criterion

.github/workflows/bench-turbotrace-against-node-nft.yml

@@ -24,6 +24,9 @@ jobs:
     runs-on: ubuntu-latest
     name: bench
 
+    env:
+      BUILD_ARGS: --release -p turbopack --features bench_against_node_nft bench_against_node_nft
+
     steps:
       - uses: actions/checkout@v3
 
@@ -49,14 +52,12 @@ jobs:
       - name: Build benchmark
         timeout-minutes: 60
         run: |
-          cargo nextest run --no-run --release \
-            -p turbopack --features bench_against_node_nft bench_against_node_nft
+          cargo nextest run --no-run ${{ env.BENCH_ARGS }}
 
       - name: Run benchmark
         timeout-minutes: 60
         run: |
-          cargo nextest run --test-threads 1 --no-fail-fast --release \
-            -p turbopack --features bench_against_node_nft bench_against_node_nft
+          cargo nextest run --test-threads 1 --no-fail-fast ${{ env.BENCH_ARGS }}
 
       - name: Show benchmark result
         run: cargo xtask nft-bench-result

.github/workflows/dispatch-next-dev-custom-bench.yml

@@ -36,7 +36,7 @@ jobs:
 
       - name: Build benchmarks
         timeout-minutes: 120
-        run: cargo  bench --no-run -p next-dev
+        run: cargo bench --no-run -p next-dev
 
       - name: Run cargo bench
         timeout-minutes: 120

.github/workflows/test.yml

@@ -471,14 +471,14 @@ jobs:
 
       - name: Build nextest
         timeout-minutes: 120
+        # We exclude turbo as it requires linking Go and all logic resides in turborepo-lib
         run: |
-          # We exclude turbo as it requires linking Go and all logic resides in turborepo-lib
           cargo nextest run --no-run --workspace --release --exclude turbo
 
       - name: Run nextest
         timeout-minutes: 120
+        # We exclude turbo as it requires linking Go and all logic resides in turborepo-lib
         run: |
-          # We exclude turbo as it requires linking Go and all logic resides in turborepo-lib
           cargo nextest run --workspace --release --no-fail-fast --exclude turbo
 
   rust_test_bench: