Skip to content

Commit

Permalink
refactor: Deleting Go code (#6956)
Browse files Browse the repository at this point in the history
### Description

LFG

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes TURBO-2011
  • Loading branch information
NicholasLYang committed Jan 30, 2024
1 parent 0a43815 commit 951a1c8
Show file tree
Hide file tree
Showing 317 changed files with 115 additions and 72,110 deletions.
37 changes: 0 additions & 37 deletions .github/actions/setup-go/action.yml

This file was deleted.

19 changes: 18 additions & 1 deletion .github/actions/setup-rust/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ inputs:
components:
description: "Comma-separated list of components to be additionally installed"
required: false

github-token:
description: "GitHub token. You can pass secrets.GITHUB_TOKEN"
required: true
shared-cache-key:
description: "A cache key that is used instead of the automatic `job`-based key, and is stable over multiple jobs."
required: false
Expand Down Expand Up @@ -53,6 +55,21 @@ runs:
shell: bash
run: rustup set default-host x86_64-pc-windows-gnu && rustup show

- name: Set Up Protoc
id: set-up-protoc
continue-on-error: true
uses: arduino/setup-protoc@v1.2.0
with:
version: "3.x"
repo-token: ${{ inputs.github-token }}

- name: Set Up Protoc (second try)
if: steps.set-up-protoc.outcome == 'failure'
uses: arduino/setup-protoc@v1.2.0
with:
version: "3.x"
repo-token: ${{ inputs.github-token }}

- name: "Add cargo problem matchers"
shell: bash
run: echo "::add-matcher::${{ github.action_path }}/matchers.json"
Expand Down
6 changes: 1 addition & 5 deletions .github/actions/setup-turborepo-environment/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,14 @@ runs:
with:
extra-flags: --no-optional

- name: "Setup Go"
uses: ./.github/actions/setup-go
with:
github-token: ${{ inputs.github-token }}

- name: "Setup Rust"
uses: ./.github/actions/setup-rust
with:
windows: ${{ inputs.windows }}
shared-cache-key: turborepo-debug-build
cache-key: ${{ inputs.target }}
save-cache: true
github-token: ${{ inputs.github-token }}

- name: "Setup capnproto"
uses: ./.github/actions/setup-capnproto
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/bench-turbopack-scheduled.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ jobs:
- uses: ./.github/actions/setup-rust
with:
shared-cache-key: benchmark-bundlers
github-token: ${{ secrets.GITHUB_TOKEN }}

- name: Clear potentially cached benchmarks
run: rm -rf target/criterion
Expand Down
44 changes: 16 additions & 28 deletions .github/workflows/bench-turbopack.yml
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,11 @@ jobs:
needs.determine_jobs.outputs.cargo_only == 'true'
name: Turbopack rust check
runs-on:
- 'self-hosted'
- 'linux'
- 'x64'
- 'metal'
- "self-hosted"
- "linux"
- "x64"
- "metal"

steps:
- name: Checkout
uses: actions/checkout@v3
Expand All @@ -138,11 +138,7 @@ jobs:
with:
components: clippy
targets: wasm32-unknown-unknown

- name: Setup Go
uses: ./.github/actions/setup-go
with:
github-token: "${{ secrets.GITHUB_TOKEN }}"
github-token: ${{ secrets.GITHUB_TOKEN }}

- name: Run cargo check release
run: |
Expand Down Expand Up @@ -188,22 +184,17 @@ jobs:
TURBOPACK_BENCH_COUNTS: 1000,10000

runs-on:
- 'self-hosted'
- 'linux'
- 'x64'
- 'metal'
- "self-hosted"
- "linux"
- "x64"
- "metal"

name: Benchmark on ${{ matrix.bench.name }}

steps:
- name: Checkout
uses: actions/checkout@v3

- name: Setup Go
uses: ./.github/actions/setup-go
with:
github-token: "${{ secrets.GITHUB_TOKEN }}"

- name: Setup Node.js
uses: ./.github/actions/setup-node

Expand All @@ -212,6 +203,7 @@ jobs:
with:
shared-cache-key: benchmark-${{ matrix.bench.cache_key }}
save-cache: true
github-token: ${{ secrets.GITHUB_TOKEN }}

- name: Clear benchmarks
run: rm -rf target/criterion
Expand Down Expand Up @@ -328,10 +320,10 @@ jobs:
title: Linux
quiet: false
runs-on:
- 'self-hosted'
- 'linux'
- 'x64'
- 'metal'
- "self-hosted"
- "linux"
- "x64"
- "metal"
# - name: macos
# title: MacOS
# quiet: true
Expand All @@ -352,18 +344,14 @@ jobs:
- name: Fetch the base branch
run: git -c protocol.version=2 fetch --no-tags --progress --no-recurse-submodules --depth=1 origin +${{ github.base_ref }}:base

- name: Setup Go
uses: ./.github/actions/setup-go
with:
github-token: "${{ secrets.GITHUB_TOKEN }}"

- name: Setup Node.js
uses: ./.github/actions/setup-node

- name: Setup Rust
uses: ./.github/actions/setup-rust
with:
shared-cache-key: benchmark-${{ matrix.os.name }}
github-token: ${{ secrets.GITHUB_TOKEN }}

- name: Benchmark and compare with base branch
uses: sokra/criterion-compare-action@main
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/bench-turborepo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ jobs:
steps:
- uses: actions/checkout@v3
- uses: ./.github/actions/setup-node
- uses: ./.github/actions/setup-go
with:
github-token: "${{ secrets.GITHUB_TOKEN }}"

- uses: ./.github/actions/setup-turborepo-environment
with:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/bench-turbotrace-against-node-nft.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,8 @@ jobs:
package-install: false

- uses: ./.github/actions/setup-rust

- uses: ./.github/actions/setup-go
with:
github-token: "${{ secrets.GITHUB_TOKEN }}"
github-token: ${{ secrets.GITHUB_TOKEN }}

- name: Install hoisted npm dependencies
working-directory: crates/turbopack/tests/node-file-trace
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/publish-npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ jobs:

- uses: ./.github/actions/setup-node
- uses: ./.github/actions/setup-rust
with:
github-token: ${{ secrets.GITHUB_TOKEN }}

- name: Build packages
run: pnpx turbo@canary run build:ts
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/test-turbopack-rust-bench-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,6 @@ jobs:
with:
save-cache: true

- name: Setup Go
uses: ./.github/actions/setup-go
with:
github-token: "${{ secrets.GITHUB_TOKEN }}"

- name: Setup Node.js
uses: ./.github/actions/setup-node
with:
Expand Down
Loading

0 comments on commit 951a1c8

Please sign in to comment.