Turbopack: Fix Next.js in cross-bundler benchmarks

This:

- Drops Next.js 11 from cross-bundler benchmarks
- Adds Next.js 14 to cross-bundler benchmarks
- Uses support for port `0` to bind to a free port in Next.js 13+

.github/workflows/bench-turbopack-scheduled.yml

@@ -40,6 +40,13 @@ jobs:
             TURBOPACK_BENCH_COUNTS: 100,500,1000
             TURBOPACK_BENCH_BUNDLERS: all
 
+          # This measures Next.js 14
+          - name: next 14
+            title: Next.js 14
+            run_args: '"(Turbopack SSR/1000|Next.js 14)"'
+            TURBOPACK_BENCH_COUNTS: 100,500,1000
+            TURBOPACK_BENCH_BUNDLERS: all
+
           # This measures Next.js 13
           - name: next 13
             title: Next.js 13
@@ -54,13 +61,6 @@ jobs:
             TURBOPACK_BENCH_COUNTS: 100,500,1000
             TURBOPACK_BENCH_BUNDLERS: all
 
-          # This measures Next.js 11
-          - name: next 11
-            title: Next.js 11
-            run_args: '"(Turbopack SSR/1000|Next.js 11)"'
-            TURBOPACK_BENCH_COUNTS: 100,500,1000
-            TURBOPACK_BENCH_BUNDLERS: all
-
           # This measures Vite
           - name: vite
             title: Vite

crates/turbopack-bench/src/bundlers/mod.rs

@@ -95,6 +95,27 @@ pub fn get_bundlers() -> Vec<Box<dyn Bundler>> {
             true,
             RenderType::ServerSideRenderedWithEvents,
         )),
+        Box::new(NextJs::new(
+            NextJsVersion::V14,
+            "Next.js 14 Turbo SSR",
+            "/page",
+            true,
+            RenderType::ServerSidePrerendered,
+        )),
+        Box::new(NextJs::new(
+            NextJsVersion::V14,
+            "Next.js 14 Turbo RSC",
+            "/app",
+            true,
+            RenderType::ServerSideRenderedWithEvents,
+        )),
+        Box::new(NextJs::new(
+            NextJsVersion::V14,
+            "Next.js 14 Turbo RCC",
+            "/client",
+            true,
+            RenderType::ServerSidePrerendered,
+        )),
         Box::new(NextJs::new(
             NextJsVersion::V13,
             "Next.js 13 Turbo SSR",
@@ -138,37 +159,44 @@ pub fn get_bundlers() -> Vec<Box<dyn Bundler>> {
             RenderType::ServerSideRenderedWithEvents,
         )),
         Box::new(NextJs::new(
-            NextJsVersion::V13,
-            "Next.js 13 webpack SSR",
+            NextJsVersion::V14,
+            "Next.js 14 webpack SSR",
             "/page",
             false,
             RenderType::ServerSidePrerendered,
         )),
         Box::new(NextJs::new(
-            NextJsVersion::V13,
-            "Next.js 13 webpack RSC",
+            NextJsVersion::V14,
+            "Next.js 14 webpack RSC",
             "/app",
             false,
             RenderType::ServerSideRenderedWithEvents,
         )),
         Box::new(NextJs::new(
-            NextJsVersion::V13,
-            "Next.js 13 webpack RCC",
+            NextJsVersion::V14,
+            "Next.js 14 webpack RCC",
             "/client",
             false,
             RenderType::ServerSidePrerendered,
         )),
         Box::new(NextJs::new(
-            NextJsVersion::V12,
-            "Next.js 12 webpack SSR",
+            NextJsVersion::V13,
+            "Next.js 13 webpack SSR",
             "/page",
             false,
             RenderType::ServerSidePrerendered,
         )),
         Box::new(NextJs::new(
-            NextJsVersion::V11,
-            "Next.js 11 webpack SSR",
-            "/page",
+            NextJsVersion::V13,
+            "Next.js 13 webpack RSC",
+            "/app",
+            false,
+            RenderType::ServerSideRenderedWithEvents,
+        )),
+        Box::new(NextJs::new(
+            NextJsVersion::V13,
+            "Next.js 13 webpack RCC",
+            "/client",
             false,
             RenderType::ServerSidePrerendered,
         )),

crates/turbopack-bench/src/bundlers/nextjs/mod.rs

@@ -21,9 +21,9 @@ use crate::{
 
 #[derive(Debug)]
 pub enum NextJsVersion {
-    V11,
     V12,
     V13,
+    V14,
     Canary,
 }
 
@@ -102,11 +102,16 @@ impl Bundler for NextJs {
                 .unwrap(),
             "dev",
             "--port",
-            // Next.js currently has a bug where requests for port 0 are ignored and it falls
-            // back to the default 3000. Use portpicker instead.
-            &portpicker::pick_unused_port()
-                .ok_or_else(|| anyhow!("failed to pick unused port"))?
-                .to_string(),
+            &match self.version {
+                NextJsVersion::V12 => {
+                    // Next.js 12 has a bug where requests for port 0 are ignored and it falls
+                    // back to the default 3000. Use portpicker instead.
+                    portpicker::pick_unused_port()
+                        .ok_or_else(|| anyhow!("failed to pick unused port"))?
+                }
+                _ => 0,
+            }
+            .to_string(),
         ])
         .current_dir(test_dir)
         .stdout(Stdio::piped())
@@ -120,7 +125,10 @@ impl Bundler for NextJs {
             proc.stdout
                 .as_mut()
                 .ok_or_else(|| anyhow!("missing stdout"))?,
-            Regex::new("started server.*url: (.*)")?,
+            match self.version {
+                NextJsVersion::V12 => Regex::new("started server.*url: (.*)"),
+                _ => Regex::new("- Local:\\s+(.*)"),
+            }?,
         )
         .ok_or_else(|| anyhow!("failed to find devserver address"))?;