Skip to content

Commit

Permalink
fix order of reverse topologic iteration (#6728)
Browse files Browse the repository at this point in the history
### Description

the ordering of reverse topological was incorrect. When pushing to the
stack we need to push items in reverse order to make sure they are
popped in correct order again.


Closes PACK-2116
  • Loading branch information
sokra committed Dec 7, 2023
1 parent 213d327 commit d168d85
Show file tree
Hide file tree
Showing 56 changed files with 182 additions and 178 deletions.
4 changes: 4 additions & 0 deletions crates/turbo-tasks/src/graph/adjacency_map.rs
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ where
stack: self
.roots
.into_iter()
.rev()
.map(|root| (ReverseTopologicalPass::Pre, root))
.collect(),
visited: HashSet::new(),
Expand All @@ -95,6 +96,7 @@ where
stack: self
.roots
.iter()
.rev()
.map(|root| (ReverseTopologicalPass::Pre, root))
.collect(),
visited: HashSet::new(),
Expand Down Expand Up @@ -161,6 +163,7 @@ where
self.stack.extend(
neighbors
.iter()
.rev()
.map(|neighbor| (ReverseTopologicalPass::Pre, neighbor.clone())),
);
}
Expand Down Expand Up @@ -211,6 +214,7 @@ where
self.stack.extend(
neighbors
.iter()
.rev()
.map(|neighbor| (ReverseTopologicalPass::Pre, neighbor)),
);
}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit d168d85

Please sign in to comment.