Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[turborepo] Failing to build on FreeBSD 13 #2339

Closed
yonas opened this issue Oct 25, 2022 · 3 comments · Fixed by #2367
Closed

[turborepo] Failing to build on FreeBSD 13 #2339

yonas opened this issue Oct 25, 2022 · 3 comments · Fixed by #2367
Labels
kind: bug Something isn't working

Comments

@yonas
Copy link
Contributor

yonas commented Oct 25, 2022

What version of Turborepo are you using?

HEAD

What package manager are you using / does the bug impact?

npm

What operating system are you using?

Other

Describe the Bug

Turbo doesn't build on FreeBSD 13.

$ sudo pkg install -y protobuf goprotobuf protobuf-c
$ go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@latest
$ npm install
...
$ npm run build

> turbo-monorepo@0.0.0 build
> pnpm -- turbo run build --filter=docs


> turbo-monorepo@0.0.0 turbo /usr/home/yonas/git/turbo
> cd cli && make turbo && cd .. && node turbow.js "run" "build" "--filter=docs"

make protoc
make[1]: Entering directory '/usr/home/yonas/git/turbo/cli'
protoc --go_out=. --go_opt=paths=source_relative \
        --go-grpc_out=. --go-grpc_opt=paths=source_relative \
        internal/turbodprotocol/turbod.proto
make[1]: Leaving directory '/usr/home/yonas/git/turbo/cli'
# Update this atomically to avoid issues with this being overwritten during use
node -e 'console.log(`package main\n\nconst turboVersion = "1.6.1"`)' > cmd/turbo/version.go.txt
mv cmd/turbo/version.go.txt cmd/turbo/version.go
CGO_ENABLED=1 go build "-ldflags=-s -w" -trimpath ./cmd/turbo
go: downloading github.com/hashicorp/go-hclog v1.2.1
go: downloading github.com/mitchellh/cli v1.1.2
go: downloading github.com/nightlyone/lockfile v1.0.0
go: downloading google.golang.org/grpc v1.46.2
go: downloading github.com/pyr-sh/dag v1.0.0
go: downloading github.com/briandowns/spinner v1.18.1
go: downloading github.com/deckarep/golang-set v1.8.0
go: downloading github.com/adrg/xdg v0.3.3
go: downloading github.com/karrick/godirwalk v1.16.1
go: downloading muzzammil.xyz/jsonc v1.0.0
go: downloading github.com/google/chrometracing v0.0.0-20210413150014-55fded0163e7
go: downloading github.com/DataDog/zstd v1.5.2
go: downloading github.com/schollz/progressbar/v3 v3.9.0
go: downloading github.com/sabhiram/go-gitignore v0.0.0-20201211210132-54b8a0bf510f
go: downloading github.com/andybalholm/crlf v0.0.0-20171020200849-670099aa064f
go: downloading github.com/iseki0/go-yarnlock v0.0.2-0.20220905015017-a2a90751cdfa
go: downloading github.com/moby/sys/sequential v0.5.0
go: downloading github.com/Masterminds/sprig v2.22.0+incompatible
go: downloading github.com/armon/go-radix v1.0.0
go: downloading github.com/posener/complete v1.2.3
go: downloading golang.org/x/crypto v0.0.0-20220411220226-7b82a4e95df4
go: downloading github.com/mitchellh/copystructure v1.0.0
go: downloading github.com/Masterminds/goutils v1.1.0
go: downloading github.com/imdario/mergo v0.3.11
go: downloading github.com/mitchellh/reflectwalk v1.0.1
# github.com/vercel/turborepo/cli/internal/tarpatch
internal/tarpatch/tar.go:56:14: undefined: sysStat
internal/tarpatch/tar.go:75:19: undefined: chmodTarEntry
make: *** [Makefile:23: turbo] Error 2
 ELIFECYCLE  Command failed with exit code 2.

Expected Behavior

npm run build should work without errors.

To Reproduce

$ npm install
$ npm run build

Reproduction Repo

No response

@yonas yonas added the kind: bug Something isn't working label Oct 25, 2022
@mehulkar mehulkar changed the title [turborepo] [turborepo] Failing to build on FreeBSD 13 Oct 25, 2022
@nathanhammond nathanhammond linked a pull request Oct 26, 2022 that will close this issue
@nathanhammond
Copy link
Contributor

We do not presently support FreeBSD as a build target so this is unsurprising. However, the fix for this particular error is trivial, so I'm happy to make the change to possibly unblock you.

(There may be additional issues hiding behind this one.)

@yonas
Copy link
Contributor Author

yonas commented Oct 26, 2022

@nathanhammond Thanks. I'll test your changes and let you know the results.

nathanhammond added a commit that referenced this issue Oct 27, 2022
Previously we allow-listed the build targets that we supported. This switches to "best effort" for Unix-y platforms that we don't support.

Closes #2339
@yonas
Copy link
Contributor Author

yonas commented Oct 27, 2022

Thanks @nathanhammond, that worked. I've created #2408 and #2407 for the remaining issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants