Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add examples with github actions #261

Closed
NixBiks opened this issue Dec 14, 2021 · 2 comments · Fixed by #930
Closed

Docs: Add examples with github actions #261

NixBiks opened this issue Dec 14, 2021 · 2 comments · Fixed by #930
Assignees
Labels
area: docs Improvements or additions to documentation area: examples Improvements or additions to examples

Comments

@NixBiks
Copy link
Contributor

NixBiks commented Dec 14, 2021

Describe the feature you'd like to request

It would be great with examples of github actions that both uses remote caching and without

Describe the solution you'd like

Maybe the current kitchen sink example could be extended.

Describe alternatives you've considered

It doesn't need to be in .github folder as an actual action but just document how a yaml could look like that efficiently uses actions/cache@v2 and turborepo's caching.

This also becomes extra interesting to see with docker examples.

@jaredpalmer jaredpalmer added area: docs Improvements or additions to documentation area: examples Improvements or additions to examples labels Dec 20, 2021
@julianYaman
Copy link

Are there any updates to this yet?

@jaredpalmer jaredpalmer changed the title Add examples with github actions Docs: Add examples with github actions Mar 16, 2022
@DaniAkash
Copy link

I'm currently following #451 (comment) implementation with the fix mentioned in #451 (comment). If this implementation actually solves caching, we just have to update the kitchen sink example with the action.yml file

@jaredpalmer jaredpalmer self-assigned this Mar 25, 2022
sokra pushed a commit that referenced this issue Oct 25, 2022
This splits dynamic loading into two phases, "skinny" and "fat" chunks. The
skinny loader chunk is shipped in the same chunk that uses dynamic `import()`
expression. Its responsibility is to load the fat loader chunk from the server.
The dynamic import has been rewritten to load this skinny chunk item, which
will load the fat chunk from the server, which will load all the chunks needed
by the dynamic import. Finally, we'll be able to load the module we're trying
to dynamically import.

Splitting the dynamic import into a quickly generatable skinny chunk item and a
slow to generate fat chunk item allows for faster incremental compilation. The
traversal won't be performed until the dynamic import is actually reached,
instead of eagerly as part of the chunk that the dynamic import appears in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation area: examples Improvements or additions to examples
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants