Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[turbopack] css source code failed: filter: alpha(opacity=100) #4092

Closed
daniel-koudouna opened this issue Mar 7, 2023 · 1 comment · Fixed by #4470
Closed

[turbopack] css source code failed: filter: alpha(opacity=100) #4092

daniel-koudouna opened this issue Mar 7, 2023 · 1 comment · Fixed by #4470
Assignees
Labels
kind: bug Something isn't working

Comments

@daniel-koudouna
Copy link

What version of Turbopack are you using?

Next 13.2.4-canary.4

What package manager are you using / does the bug impact?

Yarn v1

What operating system are you using?

Windows

Describe the Bug

Turbopack is not able to compile some CSS which contains an alpha filter with an opacity=N setting. This seems to be an older filter for IE 5~9, but seems to be valid CSS regardless. I am using a node package which uses this CSS, resulting in an error when navigating to "/":

error - [parse] [project-with-next]/node_modules/react-responsive-carousel/lib/styles/carousel.css  [project-with-next]/node_modules/react-responsive-carousel/lib/styles/carousel.css:229:29  Parsing css source code failed
     225 |       display: inline-block;
     226 |       margin: 0 8px; }
     227 |       .carousel .control-dots .dot.selected, .carousel .control-dots .dot:hover {
     228 |         opacity: 1;
         |                              v
     229 +         filter: alpha(opacity=100); }
         |                              ^
     230 |   .carousel .carousel-status {
     231 |     position: absolute;
     232 |     top: 0;
     233 |     right: 0;
  
  Expected Declaration value

Expected Behavior

Compiling without errors

To Reproduce

yarn && yarn run dev

Reproduction Repo

https://github.com/daniel-koudouna/turbo-css-opacity-parse

@daniel-koudouna daniel-koudouna added area: turbopack kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage labels Mar 7, 2023
@kdy1
Copy link
Member

kdy1 commented Mar 22, 2023

This is not a valid CSS syntax anymore.

See: swc-project/swc#7109 (comment)

@padmaia padmaia removed the needs: triage New issues get this label. Remove it after triage label Mar 22, 2023
sokra pushed a commit that referenced this issue Apr 18, 2023
### Description

This update includes an improvement of `@swc/helpers`, so we need to
update `@swc/helpers` too when updating next-swc.

### Testing Instructions

Fix WEB-744
Fix WEB-859

---

 - Fixes #2825.
 - Fixes #4092.
NicholasLYang pushed a commit to NicholasLYang/turbo that referenced this issue Apr 21, 2023
### Description

This update includes an improvement of `@swc/helpers`, so we need to
update `@swc/helpers` too when updating next-swc.

### Testing Instructions

Fix WEB-744
Fix WEB-859

---

 - Fixes vercel#2825.
 - Fixes vercel#4092.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants