Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to do group-expanded to log-order for better CI readability in Github Actions #6709

Closed
runspired opened this issue Dec 5, 2023 · 5 comments · Fixed by #7335
Closed
Labels
good first issue Good for newcomers linear: turbo Issues to sync to Linear for Turborepo team owned-by: turborepo

Comments

@runspired
Copy link

runspired commented Dec 5, 2023

Which project is this feature idea for?

Turborepo

Describe the feature you'd like to request

see title

Describe the solution you'd like

see title

Describe alternatives you've considered

choosing chaos with --log-order=stream

TURBO-1857

@runspired runspired added needs: triage New issues get this label. Remove it after triage story labels Dec 5, 2023
@anthonyshew
Copy link
Contributor

Could you provide more details? How is this different from --log-order=grouped?

@runspired
Copy link
Author

@anthonyshew log order grouped collapses all groups, makes it impossible to find which groups have failures in them.

An alternative here is to make --log-order=grouped expand any groups that have failures in them

@tknickman
Copy link
Member

@runspired groups with failures are listed at the end of the run, but agreed - runs with failures should be expanded by default!

@mehulkar mehulkar changed the title Add ability to do group-expanded to log-order for better CI readability Add ability to do group-expanded to log-order for better CI readability in Github Actions Dec 6, 2023
@mehulkar mehulkar added good first issue Good for newcomers linear: turbo Issues to sync to Linear for Turborepo team and removed needs: triage New issues get this label. Remove it after triage labels Dec 6, 2023
@maschwenk
Copy link
Contributor

I guess in terms of feasibility:

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#grouping-log-lines unclear if the expandability state is actually controllable?

I wonder if an alternative would be to pin failures to the bottom or something? Or restate them in a summary like Jest does? I know y'all have the --summary but obviously that's not super human readable.

@mehulkar
Copy link
Contributor

Since we're buffering the output until the task is done, we can just omit the group start/end markers for NZE tasks

chris-olszewski added a commit that referenced this issue Feb 14, 2024
### Description

Fixes #6709

Github Action doesn't provide a mechanism for grouping logs together and
keeping them expanded which is helpful for highlighting errors.

This PR changes the behavior so we avoid emitting the grouping
header/footer if task execution was a failure.

### Testing Instructions

Updated GH Action log grouping integration test


Closes TURBO-2320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers linear: turbo Issues to sync to Linear for Turborepo team owned-by: turborepo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants