-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to do group-expanded to log-order for better CI readability in Github Actions #6709
Comments
Could you provide more details? How is this different from |
@anthonyshew log order grouped collapses all groups, makes it impossible to find which groups have failures in them. An alternative here is to make |
@runspired groups with failures are listed at the end of the run, but agreed - runs with failures should be expanded by default! |
I guess in terms of feasibility: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#grouping-log-lines unclear if the expandability state is actually controllable? I wonder if an alternative would be to pin failures to the bottom or something? Or restate them in a summary like Jest does? I know y'all have the |
Since we're buffering the output until the task is done, we can just omit the group start/end markers for NZE tasks |
### Description Fixes #6709 Github Action doesn't provide a mechanism for grouping logs together and keeping them expanded which is helpful for highlighting errors. This PR changes the behavior so we avoid emitting the grouping header/footer if task execution was a failure. ### Testing Instructions Updated GH Action log grouping integration test Closes TURBO-2320
Which project is this feature idea for?
Turborepo
Describe the feature you'd like to request
see title
Describe the solution you'd like
see title
Describe alternatives you've considered
choosing chaos with --log-order=stream
TURBO-1857
The text was updated successfully, but these errors were encountered: