Fix parsing weird formats of the keywords field of some package.json files

[01walid]

Latest version of turborepo was having issues parsing lodash's package.json file. Because it has the keywords field defined as:

"keywords": "modules, stdlib, util"

And not using the standard format:

"keywords": ["modules", "stdlib", "util"]

• lodash version used is: v4.17.21 (latest version).

Turborepo was failing (exiting) with errors like:

 ERROR  error parsing ... /node_modules/lodash/package.json: json: cannot unmarshal string into Go struct field PackageJSON.keywords of type []string

This PR handles the above and some slightly weirder ways of defining keywords in package.json

I incremented the version, LMK if this is not the scope of this PR.

[vercel]

@01walid is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

[jaredpalmer]

Thanks! This looks awesome. If you can unwind the version bump then I can merge.

[01walid]

@jaredpalmer done! rebased off the main branch.

[jaredpalmer]

This is definitely a bug, but also my guess is you have a double star /** glob in your workspaces declaration in package.json and turbo is scanning your node_modules by accident. This is a bug in turbo. However, in the meantime, only use single stars /* in workspaces

[jaredpalmer]

Can you actually remove Keywords, Description, Homepage, License, Files, and Main from the struct? We shouldn't even waste time on these keys we aren't using.

[01walid]

This is definitely a bug, but also my guess is you have a double star /** glob in your workspaces declaration in package.json and turbo is scanning your node_modules by accident. This is a bug in turbo. However, in the meantime, only use single stars /* in workspaces

@jaredpalmer Interesting, we indeed use double star, I'll run some tests with /*.

Does this apply to exclude rules? e.g. !**/test/**?

Can you actually remove Keywords, Description, Homepage, License, Files, and Main from the struct? We shouldn't even waste time on these keys we aren't using.

Exactly my initial thought, I noticed Keywords isn't used anywhere in the codebase, but thought it might be the case in the future. Will do this.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/5mFmPi46yZdQRHRj3n5jZQckoGyw
✅ Preview: https://turbo-site-git-fork-01walid-fix-parsing-keywords-in-pack-3308f9.vercel.sh

[01walid]

@jaredpalmer I went ahead with removing the fields you mentioned.