Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved success output for create-turbo #222

Merged
merged 3 commits into from Dec 13, 2021

Conversation

seanyusa
Copy link
Contributor

@seanyusa seanyusa commented Dec 13, 2021

Improved success output for create-turbo namely for the current directory use case. (Follow-up task to #212)

Items changed (since indentation was changed so diff is not as easy to parse):

  • removed the if (projectDirIsCurrentDir) block, inlined the else logs
  • check projectDirIsCurrentDir wherever relativeProjectDir is used in the logs
  • changed docs link from https://turborepo.org -> https://turborepo.org/docs

Before

Screen Shot 2021-12-12 at 7 19 12 PM

After

(notice no cd ... lines in the success output as we are already in the project directory)
Screen Shot 2021-12-12 at 7 34 21 PM

Non-current directory case still works

Screen Shot 2021-12-12 at 7 29 48 PM

@vercel
Copy link

vercel bot commented Dec 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/6Q951heisQm5f7oV3jkeYS5BM4cr
✅ Preview: https://turbo-site-git-fork-seanyusa-create-turbo-cur-dir-output.vercel.sh

@seanyusa seanyusa changed the title Create turbo/cur dir output Improved success output for create-turbo Dec 13, 2021
@seanyusa seanyusa marked this pull request as ready for review December 13, 2021 01:44
@jaredpalmer
Copy link
Contributor

Nice

@jaredpalmer jaredpalmer merged commit 3439d75 into vercel:main Dec 13, 2021
sokra pushed a commit that referenced this pull request Oct 25, 2022
As @sokra wrote, allows for faster iteration on embedded JS files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants