The glibc patch for the Dockerfile was only applied to the builder #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
|
@rafaeltab is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
mehulkar
added
area: docs
rafaeltab
commented
Oct 26, 2022
chris-olszewski
approved these changes
Oct 26, 2022
|
I can confirm I've applied the core fix made in this change locally and it works. The confusion this caused cost me something like a day and a half of productivity, so for whatever my comment is worth, I think this should be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title explains, the Glibc patch for the Dockerfile in the
with-dockerexample was only applied to the builder stage and not the installer stage. This caused an error during the docker builds.I also updated the docs to include the updated Dockerfile.
Closes #2309 and #2286
PR #2228 previously fixed this for the builder stage, but not for the installer stage