add RSC and RCC for turbopack to benchmarks #2620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RSC: whole page is a server component RCC: whole page is a client component add `app` directory to test app
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
alexkirsz
approved these changes
Nov 7, 2022
| @@ -29,6 +29,10 @@ pub trait Bundler { | |||
| fn has_server_rendered_html(&self) -> bool { | |||
| false | |||
| } | |||
| /// There is a hydration done event emitted by client side JavaScript | |||
| fn has_interactivity(&self) -> bool { | |||
| true | |||
There was a problem hiding this comment.
You could change has_interactivity and has_server_rendered_html to return an enum.
enum InteractivityMode {
None,
HydrationDone,
}
impl InteractivityMode {
pub fn is_interactive(&self) -> bool {
match self { ... }
}
}
enum RenderMode {
Client,
Server,
}
// etc.This will make the following code clearer to understand, without having to know the order of arguments to Turbopack::new.
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
* fixup ropes * add RSC and RCC for turbopack to benchmarks RSC: whole page is a server component RCC: whole page is a client component add `app` directory to test app
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
* fixup ropes * add RSC and RCC for turbopack to benchmarks RSC: whole page is a server component RCC: whole page is a client component add `app` directory to test app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSC: whole page is a server component
RCC: whole page is a client component
add
appdirectory to test appThis also makes sure that app dir is tested as part of the benchmark tests