add different keyed app route elements #2636
Merged
+174
−193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
sokra
force-pushed
the
feat/loading-error
branch
from
f354c50
to
0290a11
Compare
shuding
approved these changes
Nov 9, 2022
alexkirsz
approved these changes
Nov 9, 2022
| "layout" => { | ||
| layout = Some(file); | ||
| "layout" | "error" | "loading" | "template" | "not-found" | "head" => { | ||
| files.insert(name.to_string(), file); |
There was a problem hiding this comment.
Could we have a FileType enum with TryFrom<String>/Into<String> impls instead?
files could either be a HashMap<FileType, file> or a FileTypeMap which has specific fields for layout, error, etc. and an Iterator<Item = (FileType, File)> impl. I think going for the more specific FileTypeMap is better here.
Benchmark for c4e66b9Click to view benchmark
|
sokra
added
the
pr: automerge
sokra
force-pushed
the
feat/loading-error
branch
from
dfa1138
to
e567b60
Compare
Benchmark for 89e81bcClick to view benchmark
|
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
* add different keyed app route elements * update for latest next.js canary version * fix header name * setup next.js version in benchmark
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
* add different keyed app route elements * update for latest next.js canary version * fix header name * setup next.js version in benchmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the missing
errorloadingtemplatenot-foundandheadnext tolayoutandpagefiles in app dirupdates app renderer code to latest next.js updates