Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry CI setup steps if needed #2692

Merged
merged 4 commits into from Nov 14, 2022
Merged

retry CI setup steps if needed #2692

merged 4 commits into from Nov 14, 2022

Conversation

sokra
Copy link
Member

@sokra sokra commented Nov 14, 2022

They sometimes fail for no reason...

@vercel
Copy link

vercel bot commented Nov 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-basic-web 🔄 Building (Inspect) Nov 14, 2022 at 8:30AM (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Nov 14, 2022 at 8:30AM (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview Nov 14, 2022 at 8:30AM (UTC)
4 Ignored Deployments
Name Status Preview Comments Updated
examples-kitchensink-blog ⬜️ Ignored (Inspect) Nov 14, 2022 at 8:30AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Nov 14, 2022 at 8:30AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Nov 14, 2022 at 8:30AM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2022 at 8:30AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2022

The following steps have failed in CI:

  • Rust lints
  • Rust tests

repo-token: ${{ inputs.github-token }}

- name: Set Up Protoc (second try)
if: steps.set-up-protoc.outcome == 'failure'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit sad about the body of these actions being repeated twice, but GH actions not having an integrated retry mechanism is really to blame here.

@sokra sokra merged commit b850698 into main Nov 14, 2022
@sokra sokra deleted the ci/retry branch November 14, 2022 09:35
@github-actions
Copy link
Contributor

Benchmark for fa32c40

Click to view benchmark
Test Base PR % sigificant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5.3±0.34ms 5.4±0.39ms +1.89%
bench_hmr_to_commit/Turbopack RCC/1000 modules 6.3±0.39ms 6.2±0.38ms -1.59%
bench_hmr_to_commit/Turbopack SSR/1000 modules 5.6±0.55ms 5.5±0.37ms -1.79%
bench_hmr_to_eval/Turbopack CSR/1000 modules 4.3±0.38ms 4.9±1.02ms +13.95%
bench_hmr_to_eval/Turbopack RCC/1000 modules 5.2±0.48ms 4.9±0.29ms -5.77%
bench_hmr_to_eval/Turbopack SSR/1000 modules 4.9±0.68ms 5.8±2.05ms +18.37%
bench_hydration/Turbopack RCC/1000 modules 3.5±0.20s 3.7±0.12s +5.71%
bench_hydration/Turbopack SSR/1000 modules 2.6±0.05s 2.6±0.04s
bench_startup/Turbopack CSR/1000 modules 1483.9±11.50ms 1495.2±22.98ms +0.76%
bench_startup/Turbopack RCC/1000 modules 2.7±0.15s 2.7±0.19s
bench_startup/Turbopack RSC/1000 modules 2.5±0.19s 2.4±0.19s -4.00%
bench_startup/Turbopack SSR/1000 modules 1967.1±22.90ms 1970.9±18.63ms +0.19%

jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
* retry setup steps if needed

* retry install nextest step

* retry browser launch

* ignore errors from PR comment failing due to PR from fork
sokra added a commit to vercel/next.js that referenced this pull request Mar 13, 2023
* retry setup steps if needed

* retry install nextest step

* retry browser launch

* ignore errors from PR comment failing due to PR from fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants