Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Yarn 2+ no longer include peer dependencies in AllDependencies #2745

Conversation

chris-olszewski
Copy link
Member

Solves the issue that @jsbrain found in #2313. Still unable get reproduce the original issue.

The underlying issue was that refine-antd listed antd as a peer dependency and direct dependency with different version constraints and the peerDependency version was overriding the direct version.

We ran into a similar issue with pnpm that I fixed in #2151. I'll be investigating if we need to do something similar for npm as well.

@vercel
Copy link

vercel bot commented Nov 17, 2022

@chris-olszewski is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Nov 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
examples-nonmonorepo 🔄 Building (Inspect) Nov 17, 2022 at 0:55AM (UTC)
5 Ignored Deployments
Name Status Preview Updated
examples-basic-web ⬜️ Ignored (Inspect) Nov 17, 2022 at 0:55AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Nov 17, 2022 at 0:55AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Nov 17, 2022 at 0:55AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Nov 17, 2022 at 0:55AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Nov 17, 2022 at 0:55AM (UTC)

@chris-olszewski chris-olszewski marked this pull request as ready for review November 17, 2022 00:17
@chris-olszewski chris-olszewski requested a review from a team as a code owner November 17, 2022 00:17
@chris-olszewski chris-olszewski merged commit 335de9c into vercel:main Nov 17, 2022
@chris-olszewski chris-olszewski deleted the chrisolszewski/turbo-554-failed-to-encode-pruned-lockfile-unable branch November 17, 2022 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants