Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon for sample many modules in benchmarks + reliability fixes #2777

Closed
wants to merge 6 commits into from

Conversation

sokra
Copy link
Member

@sokra sokra commented Nov 21, 2022

Test PR for #2750

@vercel
Copy link

vercel bot commented Nov 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

7 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Nov 21, 2022 at 8:33AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Nov 21, 2022 at 8:33AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Nov 21, 2022 at 8:33AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Nov 21, 2022 at 8:33AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Nov 21, 2022 at 8:33AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Nov 21, 2022 at 8:33AM (UTC)
turbo-site ⬜️ Ignored (Inspect) Nov 21, 2022 at 8:33AM (UTC)

@github-actions
Copy link
Contributor

Benchmark for 62ab6c7

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 7314.99µs ± 38.92µs N/A N/A N/A
bench_hmr_to_commit/Turbopack RCC/1000 modules 7421.58µs ± 42.38µs N/A N/A N/A
bench_hmr_to_commit/Turbopack RSC/1000 modules 902.75ms ± 9.95ms N/A N/A N/A
bench_hmr_to_commit/Turbopack SSR/1000 modules 7295.46µs ± 32.41µs N/A N/A N/A
bench_hmr_to_eval/Turbopack CSR/1000 modules 6310.57µs ± 29.91µs 6774.04µs ± 56.67µs +7.34% +4.56%
bench_hmr_to_eval/Turbopack RCC/1000 modules 6449.16µs ± 21.53µs 7067.54µs ± 63.14µs +9.59% +6.92%
bench_hmr_to_eval/Turbopack SSR/1000 modules 6257.55µs ± 33.50µs 6836.29µs ± 75.75µs +9.25% +5.70%
bench_hydration/Turbopack RCC/1000 modules 3403.80ms ± 37.90ms N/A N/A N/A
bench_hydration/Turbopack RSC/1000 modules 2582.80ms ± 28.26ms N/A N/A N/A
bench_hydration/Turbopack SSR/1000 modules 2540.62ms ± 21.69ms N/A N/A N/A
bench_startup/Turbopack CSR/1000 modules 1422.16ms ± 6.90ms N/A N/A N/A
bench_startup/Turbopack RCC/1000 modules 2650.99ms ± 28.34ms 2358.54ms ± 7.01ms -11.03% -8.55%
bench_startup/Turbopack RSC/1000 modules 2290.44ms ± 51.77ms 2130.20ms ± 14.30ms -7.00% -1.29%
bench_startup/Turbopack SSR/1000 modules 1893.85ms ± 2.80ms 1710.54ms ± 10.52ms -9.68% -8.30%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 7314.99µs ± 38.92µs N/A N/A N/A
bench_hmr_to_commit/Turbopack RCC/1000 modules 7421.58µs ± 42.38µs N/A N/A N/A
bench_hmr_to_commit/Turbopack RSC/1000 modules 902.75ms ± 9.95ms N/A N/A N/A
bench_hmr_to_commit/Turbopack SSR/1000 modules 7295.46µs ± 32.41µs N/A N/A N/A
bench_hmr_to_eval/Turbopack CSR/1000 modules 6310.57µs ± 29.91µs 6774.04µs ± 56.67µs +7.34% +4.56%
bench_hmr_to_eval/Turbopack RCC/1000 modules 6449.16µs ± 21.53µs 7067.54µs ± 63.14µs +9.59% +6.92%
bench_hmr_to_eval/Turbopack SSR/1000 modules 6257.55µs ± 33.50µs 6836.29µs ± 75.75µs +9.25% +5.70%
bench_hydration/Turbopack RCC/1000 modules 3403.80ms ± 37.90ms N/A N/A N/A
bench_hydration/Turbopack RSC/1000 modules 2582.80ms ± 28.26ms N/A N/A N/A
bench_hydration/Turbopack SSR/1000 modules 2540.62ms ± 21.69ms N/A N/A N/A
bench_startup/Turbopack CSR/1000 modules 1422.16ms ± 6.90ms N/A N/A N/A
bench_startup/Turbopack RCC/1000 modules 2650.99ms ± 28.34ms 2358.54ms ± 7.01ms -11.03% -8.55%
bench_startup/Turbopack RSC/1000 modules 2290.44ms ± 51.77ms 2130.20ms ± 14.30ms -7.00% -1.29%
bench_startup/Turbopack SSR/1000 modules 1893.85ms ± 2.80ms 1710.54ms ± 10.52ms -9.68% -8.30%

avoid HMR code when not needed

call useEffect only when needed
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2022

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Rust lints
  • Rust benchmark tests

See workflow summary for details

@github-actions
Copy link
Contributor

Benchmark for 7c46fe3

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 7297.03µs ± 36.37µs 8320.63µs ± 52.33µs +14.03% +11.48%
bench_hmr_to_commit/Turbopack RCC/1000 modules 7414.92µs ± 35.41µs N/A N/A N/A
bench_hmr_to_commit/Turbopack RSC/1000 modules 925.82ms ± 7.62ms 831.76ms ± 28.03ms -10.16% -2.50%
bench_hmr_to_commit/Turbopack SSR/1000 modules 7331.35µs ± 19.10µs 8407.97µs ± 61.08µs +14.69% +12.43%
bench_hmr_to_eval/Turbopack CSR/1000 modules 6412.39µs ± 39.48µs 6851.89µs ± 47.04µs +6.85% +4.11%
bench_hmr_to_eval/Turbopack RCC/1000 modules 6483.44µs ± 26.40µs 7065.37µs ± 47.24µs +8.98% +6.65%
bench_hmr_to_eval/Turbopack SSR/1000 modules 6438.78µs ± 45.65µs 6911.01µs ± 27.43µs +7.33% +4.99%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 7297.03µs ± 36.37µs 8320.63µs ± 52.33µs +14.03% +11.48%
bench_hmr_to_commit/Turbopack RCC/1000 modules 7414.92µs ± 35.41µs N/A N/A N/A
bench_hmr_to_commit/Turbopack RSC/1000 modules 925.82ms ± 7.62ms 831.76ms ± 28.03ms -10.16% -2.50%
bench_hmr_to_commit/Turbopack SSR/1000 modules 7331.35µs ± 19.10µs 8407.97µs ± 61.08µs +14.69% +12.43%
bench_hmr_to_eval/Turbopack CSR/1000 modules 6412.39µs ± 39.48µs 6851.89µs ± 47.04µs +6.85% +4.11%
bench_hmr_to_eval/Turbopack RCC/1000 modules 6483.44µs ± 26.40µs 7065.37µs ± 47.24µs +8.98% +6.65%
bench_hmr_to_eval/Turbopack SSR/1000 modules 6438.78µs ± 45.65µs 6911.01µs ± 27.43µs +7.33% +4.99%
bench_hydration/Turbopack RCC/1000 modules 3445.76ms ± 42.17ms 3414.95ms ± 48.09ms -0.89%
bench_hydration/Turbopack RSC/1000 modules 2621.19ms ± 33.89ms 2642.74ms ± 48.81ms +0.82%
bench_hydration/Turbopack SSR/1000 modules 2532.50ms ± 9.83ms 2598.08ms ± 25.77ms +2.59%
bench_startup/Turbopack CSR/1000 modules 1428.90ms ± 3.94ms 1440.55ms ± 6.26ms +0.82%
bench_startup/Turbopack RCC/1000 modules 2600.76ms ± 49.41ms 2708.60ms ± 26.59ms +4.15%
bench_startup/Turbopack RSC/1000 modules 2250.85ms ± 37.12ms 2230.26ms ± 31.42ms -0.91%
bench_startup/Turbopack SSR/1000 modules 1923.85ms ± 19.04ms 1929.61ms ± 14.41ms +0.30%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants