@next/font/google: Hash filenames used in virtual file paths

[wbinnssmith]

Fixes WEB-289.

This uses hex-encoded hashes so that filenames for virtual assets for @next/font/google are unique. Previously, every virtual asset generated by @next/font/google would have the same path to the asset, impacting the quality of sourcemaps. This also keeps the basename consistent between the js and css module counterparts.

This also implements DeterministicHash for the &str type.

Test Plan: Given

import {Inter} from '@next/font/google';
import {Open_Sans} from '@next/font/google';

const inter = Inter({weight: "500"});
const sans = Open_Sans({weight: "500"});

...Chrome shows a tree of sourcemapped sources of:

[embedded_modules]/@vercel/turbopack-next
  internal
    font/google
      inter_34a0e3053298f029.js
      open_sans_a9468dae095a104a.js
      inter_34a0e3053298f029.module.css
      open_sans_a9468dae095a104a.module.css

and that the contents of each pair of basenames reflect the same imported font.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
examples-nonmonorepo	🔄 Building (Inspect)			Dec 13, 2022 at 1:41AM (UTC)
turbo-site	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Dec 13, 2022 at 1:41AM (UTC)

6 Ignored Deployments

Name	Status	Preview	Comments	Updated
examples-basic-web	⬜️ Ignored (Inspect)			Dec 13, 2022 at 1:41AM (UTC)
examples-cra-web	⬜️ Ignored (Inspect)			Dec 13, 2022 at 1:41AM (UTC)
examples-designsystem-docs	⬜️ Ignored (Inspect)			Dec 13, 2022 at 1:41AM (UTC)
examples-kitchensink-blog	⬜️ Ignored (Inspect)			Dec 13, 2022 at 1:41AM (UTC)
examples-native-web	⬜️ Ignored (Inspect)			Dec 13, 2022 at 1:41AM (UTC)
examples-svelte-web	⬜️ Ignored (Inspect)			Dec 13, 2022 at 1:41AM (UTC)

[wbinnssmith]

Current dependencies on/for this PR:

• main
  • PR [7/n] @next/font/google: Add font weight, style to css and js properties #2963
    • PR turbo-tasks-fetch: Emit issues on failed fetches #2964
      • PR Unmark @next/font/google as unsupported and move feature to gate @next/font/local only #2965
        • PR @next/font/google: Hash filenames used in virtual file paths #2978 👈

This comment was auto-generated by Graphite.

[github-actions]

Benchmark for cab5e3e

Click to view benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	8553.02µs ± 61.58µs	8493.09µs ± 47.17µs	-0.70%
bench_hmr_to_commit/Turbopack RCC/1000 modules	8839.16µs ± 72.61µs	8807.87µs ± 70.65µs	-0.35%
bench_hmr_to_commit/Turbopack RSC/1000 modules	868.47ms ± 27.24ms	905.78ms ± 13.30ms	+4.30%
bench_hmr_to_commit/Turbopack SSR/1000 modules	8560.36µs ± 71.30µs	8564.55µs ± 57.93µs	+0.05%
bench_hmr_to_eval/Turbopack CSR/1000 modules	7502.36µs ± 53.87µs	7557.45µs ± 89.07µs	+0.73%
bench_hmr_to_eval/Turbopack RCC/1000 modules	7645.78µs ± 58.84µs	7599.51µs ± 70.11µs	-0.61%
bench_hmr_to_eval/Turbopack SSR/1000 modules	7534.57µs ± 63.08µs	7544.18µs ± 56.75µs	+0.13%
bench_hydration/Turbopack RCC/1000 modules	3563.75ms ± 27.91ms	3526.55ms ± 13.75ms	-1.04%
bench_hydration/Turbopack RSC/1000 modules	2738.88ms ± 30.43ms	2713.19ms ± 30.08ms	-0.94%
bench_hydration/Turbopack SSR/1000 modules	2992.94ms ± 24.80ms	3029.50ms ± 9.54ms	+1.22%
bench_startup/Turbopack CSR/1000 modules	1454.50ms ± 4.17ms	1445.75ms ± 8.51ms	-0.60%
bench_startup/Turbopack RCC/1000 modules	2684.06ms ± 34.35ms	2734.14ms ± 19.83ms	+1.87%
bench_startup/Turbopack RSC/1000 modules	2354.58ms ± 39.85ms	2277.08ms ± 36.30ms	-3.29%
bench_startup/Turbopack SSR/1000 modules	2325.20ms ± 24.85ms	2355.35ms ± 5.67ms	+1.30%

[github-actions]

🟢 CI successful 🟢

Thanks

[jridgewell]

Nit: There's no need to build a vec for this, using a Xxh3Hash64Hasher instance will allow you to compute this piecemeal.

Also, is this query sorted? We should consider ?a=b&c=d to be equal to ?c=d&a=b for hashing.