feat(turbo-updater): only request latest for now #3017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
Benchmark for 1f96f39Click to view benchmark
|
|
tknickman
commented
Dec 15, 2022
tknickman
added a commit
that referenced
this pull request
Dec 15, 2022
We can overload name because update-informer allows name in an owner/name format and then splits the name but includes the owner in the cached file. So we can do something like canary/turbo, latest/turbo etc. We should still send a fix upstream to support this more formally. But this should work for now. Updated version of #3017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, update_informer does not support caching the correct version per tag. There's only one file right now that is storing the latest known version, so if a canary version makes it way in there (if you ran with a canary first, or if you were running a canary when the interval expired and it refetched latest) then that's going to be the latest for all other versions until the interval expires and we reach out to the registry again.
We need to update this on the update-informer side, but for now I think we should yank updates per tag, stick with latest only, and drop our interval to 6 hours (implemented in this PR)
This will guarantee that the only users who will see this update notification incorrectly are users who have both 1.7.0-canary.x and 1.7.0. AND they run 1.7.0-canary.x first, and then go back to running 1.7.0. Even if this does occur, it would auto fix in 6 hours when the first check to the registry goes out and we return and store the real latest version.