Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add progress output to command line #3061

Merged
merged 2 commits into from Dec 20, 2022
Merged

add progress output to command line #3061

merged 2 commits into from Dec 20, 2022

Conversation

sokra
Copy link
Member

@sokra sokra commented Dec 18, 2022

add counting seconds when something is happening. Only starts to show when compilation takes more than 1s

@vercel
Copy link

vercel bot commented Dec 18, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-basic-web 🔄 Building (Inspect) Dec 20, 2022 at 3:55PM (UTC)
examples-nonmonorepo 🔄 Building (Inspect) Dec 20, 2022 at 3:55PM (UTC)
6 Ignored Deployments
Name Status Preview Comments Updated
examples-cra-web ⬜️ Ignored (Inspect) Dec 20, 2022 at 3:55PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Dec 20, 2022 at 3:55PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Dec 20, 2022 at 3:55PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Dec 20, 2022 at 3:55PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Dec 20, 2022 at 3:55PM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2022 at 3:55PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2022 •
edited

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Determining jobs

See workflow summary for details

@github-actions
Copy link
Contributor

Benchmark for 1b5e7af

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8405.89µs ± 35.44µs 8479.85µs ± 64.51µs +0.88%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8769.20µs ± 41.02µs 8730.48µs ± 66.55µs -0.44%
bench_hmr_to_commit/Turbopack RSC/1000 modules 833.46ms ± 22.40ms 818.89ms ± 9.20ms -1.75%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8579.64µs ± 77.84µs 8522.69µs ± 46.63µs -0.66%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7479.89µs ± 75.67µs 7438.20µs ± 43.36µs -0.56%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7587.76µs ± 44.13µs 7622.15µs ± 68.34µs +0.45%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7552.32µs ± 48.03µs 7431.08µs ± 40.50µs -1.61%
bench_hydration/Turbopack RCC/1000 modules 3886.52ms ± 40.07ms 3878.91ms ± 24.72ms -0.20%
bench_hydration/Turbopack RSC/1000 modules 3098.47ms ± 54.80ms 3115.16ms ± 47.84ms +0.54%
bench_hydration/Turbopack SSR/1000 modules 3354.49ms ± 21.26ms 3331.16ms ± 20.44ms -0.70%
bench_startup/Turbopack CSR/1000 modules 1802.04ms ± 11.18ms 1800.91ms ± 5.52ms -0.06%
bench_startup/Turbopack RCC/1000 modules 3073.41ms ± 29.12ms 3127.10ms ± 21.40ms +1.75%
bench_startup/Turbopack RSC/1000 modules 2673.97ms ± 43.39ms 2717.41ms ± 43.81ms +1.62%
bench_startup/Turbopack SSR/1000 modules 2736.10ms ± 12.80ms 2707.51ms ± 17.45ms -1.04%

@sokra sokra requested a review from alexkirsz December 18, 2022 14:52
@sokra sokra marked this pull request as ready for review December 18, 2022 14:52
@sokra sokra requested a review from a team as a code owner December 18, 2022 14:52
alexkirsz
alexkirsz approved these changes Dec 19, 2022
View reviewed changes
crates/next-dev/src/lib.rs Outdated Show resolved Hide resolved
crates/next-dev/src/lib.rs Outdated Show resolved Hide resolved
@sokra @alexkirsz
Apply suggestions from code review
f0c8038 
Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
@sokra sokra merged commit 34c358e into main Dec 20, 2022
@sokra sokra deleted the sokra/cli-progress branch December 20, 2022 15:54
kwonoj added a commit to kwonoj/turbo that referenced this pull request Dec 21, 2022
@kwonoj
Revert "add progress output to command line (vercel#3061)"
d170a2e 
This reverts commit 34c358e.
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@sokra @alexkirsz
add progress output to command line (vercel/turbo#3061)
6128d5a 
add counting seconds when something is happening. Only starts to show
when compilation takes more than 1s

Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
sokra added a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@sokra @alexkirsz
add progress output to command line (vercel/turbo#3061)
13a02d3 
add counting seconds when something is happening. Only starts to show
when compilation takes more than 1s

Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkirsz alexkirsz alexkirsz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sokra @alexkirsz