Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nitpicks with load-next-config #3064

Merged
merged 1 commit into from Dec 18, 2022
Merged

Conversation

jridgewell
Copy link
Contributor

Re: code review nits from #2955

Re: code review nits from #2955
@jridgewell jridgewell requested a review from a team as a code owner December 18, 2022 05:29
@vercel
Copy link

vercel bot commented Dec 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-cra-web 🔄 Building (Inspect) Dec 18, 2022 at 6:11AM (UTC)
examples-kitchensink-blog 🔄 Building (Inspect) Dec 18, 2022 at 6:11AM (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 18, 2022 at 6:11AM (UTC)
5 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Dec 18, 2022 at 6:11AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Dec 18, 2022 at 6:11AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Dec 18, 2022 at 6:11AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Dec 18, 2022 at 6:11AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Dec 18, 2022 at 6:11AM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2022

🟢 CI successful 🟢

Thanks

@github-actions
Copy link
Contributor

Benchmark for 28c1366

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 7963.17µs ± 70.93µs 7904.05µs ± 48.26µs -0.74%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8244.85µs ± 54.90µs 8300.31µs ± 74.22µs +0.67%
bench_hmr_to_commit/Turbopack RSC/1000 modules 856.93ms ± 16.75ms 830.91ms ± 19.99ms -3.04%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8022.12µs ± 36.95µs 7987.48µs ± 56.17µs -0.43%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7008.20µs ± 77.29µs 7008.40µs ± 52.28µs +0.00%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7163.00µs ± 67.26µs 7194.59µs ± 25.82µs +0.44%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7092.18µs ± 33.17µs 7064.39µs ± 17.72µs -0.39%
bench_hydration/Turbopack RCC/1000 modules 3873.72ms ± 24.96ms 3892.34ms ± 35.97ms +0.48%
bench_hydration/Turbopack RSC/1000 modules 2980.18ms ± 31.99ms 3017.13ms ± 33.51ms +1.24%
bench_hydration/Turbopack SSR/1000 modules 3290.96ms ± 9.36ms 3296.03ms ± 10.97ms +0.15%
bench_startup/Turbopack CSR/1000 modules 1774.14ms ± 7.07ms 1772.29ms ± 14.72ms -0.10%
bench_startup/Turbopack RCC/1000 modules 3051.25ms ± 26.49ms 3009.49ms ± 37.38ms -1.37%
bench_startup/Turbopack RSC/1000 modules 2553.81ms ± 31.63ms 2606.98ms ± 38.34ms +2.08%
bench_startup/Turbopack SSR/1000 modules 2692.44ms ± 11.90ms 2690.31ms ± 32.28ms -0.08%

@Brooooooklyn Brooooooklyn merged commit 97baee4 into main Dec 18, 2022
@Brooooooklyn Brooooooklyn deleted the load-next-config-nits branch December 18, 2022 13:03
jridgewell added a commit to vercel/next.js that referenced this pull request Mar 10, 2023
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants