add rules to alter resolve/module context depending on context path #3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
This comment was marked as outdated.
This comment was marked as outdated.
Benchmark for 706125dClick to view benchmark
|
alexkirsz
approved these changes
Dec 21, 2022
Comment on lines
85
to
100
| rules: vec![( | ||
| ContextCondition::InDirectory("node_modules".to_string()), | ||
| Some( | ||
| ResolveOptionsContext { | ||
| enable_node_modules: true, | ||
| custom_conditions: vec!["development".to_string()], | ||
| import_map: Some(next_client_import_map), | ||
| fallback_import_map: Some(next_client_fallback_import_map), | ||
| resolved_map: Some(next_client_resolved_map), | ||
| browser: true, | ||
| module: true, | ||
| ..Default::default() | ||
| } | ||
| .cell(), | ||
| ), | ||
| )], |
There was a problem hiding this comment.
This should be:
let shared_options = ResolveOptionsContext {
enable_node_modules: true,
custom_conditions: vec!["development".to_string()],
import_map: Some(next_client_import_map),
fallback_import_map: Some(next_client_fallback_import_map),
resolved_map: Some(next_client_resolved_map),
browser: true,
module: true,
..Default::default()
};Then spread that into both this and the one above. This way, if we ever add new keys in the future, they will be applied to both correctly.
The same remark applies to all of the below.
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Add comments to the public items.
| if let &Some(new_context) = new_context { | ||
| return Ok(ModuleOptionsVc::new(path, new_context)); | ||
| } else { | ||
| break; |
There was a problem hiding this comment.
Do we ever run into that case? I think we only have Some( above, maybe it shouldn't be an option?
sokra
added
the
pr: automerge
jridgewell
approved these changes
Dec 21, 2022
Benchmark for e9099ad
Click to view full benchmark
|
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WEB-43
Closes #3104