Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid creating a new api node.js pool for every request #3110

Merged
merged 2 commits into from Dec 21, 2022
Merged

Avoid creating a new api node.js pool for every request #3110

merged 2 commits into from Dec 21, 2022

Conversation

sokra
Copy link
Member

@sokra sokra commented Dec 21, 2022 •
edited by jridgewell

Fixes WEB-141.

@vercel
Copy link

vercel bot commented Dec 21, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Dec 21, 2022 at 3:58PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Dec 21, 2022 at 3:58PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Dec 21, 2022 at 3:58PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Dec 21, 2022 at 3:58PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Dec 21, 2022 at 3:58PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Dec 21, 2022 at 3:58PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Dec 21, 2022 at 3:58PM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2022 at 3:58PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2022 •
edited

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Determining jobs

See workflow summary for details

@github-actions
Copy link
Contributor

Benchmark for f67d3f0

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack RSC/1000 modules 744.12ms ± 2.78ms 437.82ms ± 1.82ms -41.16% -40.23%
bench_hydration/Turbopack RSC/1000 modules 2681.24ms ± 9.59ms 2633.36ms ± 7.07ms -1.79% -0.55%
bench_startup/Turbopack RSC/1000 modules 2311.54ms ± 7.82ms 2250.09ms ± 8.53ms -2.66% -1.25%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 7411.84µs ± 50.04µs 7360.68µs ± 41.55µs -0.69%
bench_hmr_to_commit/Turbopack RCC/1000 modules 7701.65µs ± 107.05µs 7755.90µs ± 59.00µs +0.70%
bench_hmr_to_commit/Turbopack RSC/1000 modules 744.12ms ± 2.78ms 437.82ms ± 1.82ms -41.16% -40.23%
bench_hmr_to_commit/Turbopack SSR/1000 modules 7471.33µs ± 39.96µs 7497.97µs ± 47.38µs +0.36%
bench_hmr_to_eval/Turbopack CSR/1000 modules 6526.55µs ± 65.03µs 6473.16µs ± 43.21µs -0.82%
bench_hmr_to_eval/Turbopack RCC/1000 modules 6666.08µs ± 49.18µs 6687.55µs ± 31.86µs +0.32%
bench_hmr_to_eval/Turbopack SSR/1000 modules 6689.89µs ± 63.88µs 6586.10µs ± 50.57µs -1.55%
bench_hydration/Turbopack RCC/1000 modules 3231.65ms ± 10.22ms 3222.88ms ± 8.89ms -0.27%
bench_hydration/Turbopack RSC/1000 modules 2681.24ms ± 9.59ms 2633.36ms ± 7.07ms -1.79% -0.55%
bench_hydration/Turbopack SSR/1000 modules 2553.81ms ± 14.54ms 2540.20ms ± 6.97ms -0.53%
bench_startup/Turbopack CSR/1000 modules 1569.93ms ± 5.76ms 1572.52ms ± 3.94ms +0.16%
bench_startup/Turbopack RCC/1000 modules 2417.32ms ± 7.65ms 2399.42ms ± 5.19ms -0.74%
bench_startup/Turbopack RSC/1000 modules 2311.54ms ± 7.82ms 2250.09ms ± 8.53ms -2.66% -1.25%
bench_startup/Turbopack SSR/1000 modules 1982.68ms ± 5.20ms 1987.68ms ± 9.51ms +0.25%

@sokra sokra marked this pull request as ready for review December 21, 2022 13:21
@sokra sokra requested a review from a team as a code owner December 21, 2022 13:21
@sokra sokra requested a review from alexkirsz December 21, 2022 13:22
@sokra @alexkirsz
Update crates/next-core/src/server_rendered_source.rs
6e24f40 
Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
@sokra sokra merged commit 058f375 into main Dec 21, 2022
@sokra sokra deleted the sokra/web-361-avoid-spawning-a-new-nodejs-pool-for branch December 21, 2022 15:57
@jridgewell
Copy link
Contributor

jridgewell commented Dec 21, 2022 •
edited

I wonder if this also fixes WEB-141?

@jridgewell
Copy link
Contributor

jridgewell commented Dec 21, 2022 •
edited

Yup, seems resolved now.

jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@sokra @alexkirsz
Avoid creating a new api node.js pool for every request (vercel/turbo…
d0b6117 
…#3110)

Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
sokra added a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@sokra @alexkirsz
Avoid creating a new api node.js pool for every request (vercel/turbo…
91d2af2 
…#3110)

Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkirsz alexkirsz alexkirsz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sokra @jridgewell @alexkirsz