separate typescript with types from typescript transformed #3118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
jridgewell
suggested changes
Dec 22, 2022
| @@ -69,6 +69,7 @@ use crate::{ | |||
| pub enum EcmascriptModuleAssetType { | |||
| Ecmascript, | |||
| Typescript, | |||
| TypescriptSource, | |||
There was a problem hiding this comment.
Please add a comment explaining the difference between TS and TSSource. It seems TSSource is code that the dev is writing, where TS is code they're importing?
Comment on lines
224
to
228
| vec![if enable_typescript_transform { | ||
| ModuleRuleEffect::ModuleType(ModuleType::Typescript(ts_transforms)) | ||
| } else { | ||
| ModuleRuleEffect::ModuleType(ModuleType::TypescriptSource(ts_transforms)) | ||
| }], |
There was a problem hiding this comment.
If we're inside node_modules, shouldn't we disable type checking? Ie, only use TS, not TSSource.
Comment on lines
213
to
217
| vec![if enable_typescript_transform { | ||
| ModuleRuleEffect::ModuleType(ModuleType::Typescript(ts_app_transforms)) | ||
| } else { | ||
| ModuleRuleEffect::ModuleType(ModuleType::TypescriptSource(ts_app_transforms)) | ||
| }], |
There was a problem hiding this comment.
Opposite here, shouldn't this always be TSSource?
|
Benchmark for 301330fClick to view benchmark
|
jridgewell
approved these changes
Dec 22, 2022
| | EcmascriptModuleAssetType::TypescriptDeclaration => true, | ||
| EcmascriptModuleAssetType::Ecmascript => false, | ||
| EcmascriptModuleAssetType::Typescript | EcmascriptModuleAssetType::Ecmascript => false, | ||
| }; | ||
|
|
||
| let parsed = parse(source, ty, transforms); |
There was a problem hiding this comment.
Nit: there are some references to is_typescript in the code below that are not actually used, it's just a parameter that exists to be passed to other code that also doesn't use it and passes down.
jridgewell
approved these changes
Dec 22, 2022
| Ok(BoolVc::cell( | ||
| self.await?.resolve_options_context.await?.enable_types, | ||
| context.enable_types && context.enable_typescript, |
There was a problem hiding this comment.
Maybe this should be an enum instead of 2 bools?
sokra
force-pushed
the
sorka/bugfix/type-references
branch
from
8fbb292
to
b535af2
Compare
sokra
force-pushed
the
sorka/bugfix/type-references
branch
from
b535af2
to
cb80040
Compare
Benchmark for 8f5b08e
Click to view full benchmark
|
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
…rbo#3118) fixes weird typescript errors caused by types being referenced by .ts files
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
…rbo#3118) fixes weird typescript errors caused by types being referenced by .ts files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes weird typescript errors caused by types being referenced by .ts files