fix windows paths with --root #3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
kwonoj
approved these changes
Jan 12, 2023
Benchmark for b4f0200Click to view benchmark
|
🟢 CI successful 🟢Thanks |
sokra
deleted the
sokra/web-406-turbopack-crashes-on-windows-when---root
branch
jridgewell
reviewed
Jan 12, 2023
| let project_path = fs.root().join(project_relative); | ||
| .unwrap_or(project_relative) | ||
| .replace(MAIN_SEPARATOR, "/"); | ||
| let project_path = fs.root().join(&project_relative); |
There was a problem hiding this comment.
This should have been detected by the join call, but we run our tests stripping out debug_asserts.
There was a problem hiding this comment.
turbo/.github/workflows/test.yml
Line 482 in 368ca0b
alexkirsz
reviewed
Jan 12, 2023
| .unwrap_or(project_relative); | ||
| let project_path = fs.root().join(project_relative); | ||
| .unwrap_or(project_relative) | ||
| .replace(MAIN_SEPARATOR, "/"); |
There was a problem hiding this comment.
This should use sys_to_unix instead
This was referenced Jan 20, 2023
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.