Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: prefixed aliases must not be in fallback aliases #3291

Merged
merged 1 commit into from Jan 12, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 12, 2023

No description provided.

@sokra sokra requested a review from a team as a code owner January 12, 2023 15:37
@vercel
Copy link

vercel bot commented Jan 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Jan 12, 2023 at 3:37PM (UTC)
9 Ignored Deployments
Name Status Preview Updated
examples-basic-web ⬜️ Ignored (Inspect) Jan 12, 2023 at 3:37PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Jan 12, 2023 at 3:37PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Jan 12, 2023 at 3:37PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jan 12, 2023 at 3:37PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Jan 12, 2023 at 3:37PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 12, 2023 at 3:37PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Jan 12, 2023 at 3:37PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Jan 12, 2023 at 3:37PM (UTC)
turbo-vite-web ⬜️ Ignored (Inspect) Jan 12, 2023 at 3:37PM (UTC)

@ForsakenHarmony ForsakenHarmony changed the title node: prefixed aliases must not in fallback aliases node: prefixed aliases must not be in fallback aliases Jan 12, 2023
@sokra sokra merged commit dfaac06 into main Jan 12, 2023
@sokra sokra deleted the sokra/web-413-using-nodequerystring-on-client-side branch January 12, 2023 16:33
@github-actions
Copy link
Contributor

Benchmark for a247125

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 1679.86ms ± 3.39ms 1666.37ms ± 3.17ms -0.80% -0.02%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8680.60µs ± 41.50µs 8680.21µs ± 63.03µs -0.00%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8853.30µs ± 74.02µs 8855.60µs ± 69.03µs +0.03%
bench_hmr_to_commit/Turbopack RSC/1000 modules 480.18ms ± 2.12ms 479.25ms ± 1.52ms -0.19%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8711.63µs ± 64.34µs 8780.97µs ± 59.28µs +0.80%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7759.19µs ± 47.06µs 7751.12µs ± 83.65µs -0.10%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7769.49µs ± 64.43µs 7723.61µs ± 60.00µs -0.59%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7739.70µs ± 39.60µs 7759.20µs ± 72.11µs +0.25%
bench_hydration/Turbopack RCC/1000 modules 3484.54ms ± 14.53ms 3478.25ms ± 12.41ms -0.18%
bench_hydration/Turbopack RSC/1000 modules 2935.44ms ± 9.54ms 2946.38ms ± 11.73ms +0.37%
bench_hydration/Turbopack SSR/1000 modules 2749.69ms ± 12.53ms 2750.51ms ± 9.37ms +0.03%
bench_startup/Turbopack CSR/1000 modules 1679.86ms ± 3.39ms 1666.37ms ± 3.17ms -0.80% -0.02%
bench_startup/Turbopack RCC/1000 modules 2615.76ms ± 7.33ms 2590.62ms ± 10.05ms -0.96%
bench_startup/Turbopack RSC/1000 modules 2436.96ms ± 8.96ms 2444.95ms ± 11.78ms +0.33%
bench_startup/Turbopack SSR/1000 modules 2075.79ms ± 6.53ms 2095.90ms ± 5.22ms +0.97%

@github-actions
Copy link
Contributor

🟢 CI successful 🟢

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants