Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic test for next/dynamic #3307

Merged
merged 1 commit into from Jan 13, 2023
Merged

Add basic test for next/dynamic #3307

merged 1 commit into from Jan 13, 2023

Conversation

alexkirsz
Copy link
Contributor

This adds two basic tests for next/dynamic:

  • one ensures that SSR supports dynamic components;
  • the other ensures that SSR doesn't run when ssr: false.

@alexkirsz alexkirsz requested a review from a team as a code owner January 13, 2023 14:17
@vercel
Copy link

vercel bot commented Jan 13, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

10 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Jan 13, 2023 at 2:17PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Jan 13, 2023 at 2:17PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Jan 13, 2023 at 2:17PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jan 13, 2023 at 2:17PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Jan 13, 2023 at 2:17PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 13, 2023 at 2:17PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Jan 13, 2023 at 2:17PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Jan 13, 2023 at 2:17PM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2023 at 2:17PM (UTC)
turbo-vite-web ⬜️ Ignored (Inspect) Jan 13, 2023 at 2:17PM (UTC)

@github-actions
Copy link
Contributor

Benchmark for de4dc3d

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8861.26µs ± 46.54µs 8855.16µs ± 42.92µs -0.07%
bench_hmr_to_commit/Turbopack RCC/1000 modules 9095.79µs ± 68.56µs 9163.46µs ± 56.61µs +0.74%
bench_hmr_to_commit/Turbopack RSC/1000 modules 481.97ms ± 1.21ms 481.13ms ± 2.34ms -0.17%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8959.70µs ± 50.36µs 9069.51µs ± 53.69µs +1.23%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7855.90µs ± 52.57µs 7908.21µs ± 91.68µs +0.67%
bench_hmr_to_eval/Turbopack RCC/1000 modules 8018.28µs ± 60.84µs 7977.65µs ± 67.75µs -0.51%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7895.06µs ± 46.90µs 7949.13µs ± 65.01µs +0.68%
bench_hydration/Turbopack RCC/1000 modules 3418.81ms ± 7.37ms 3431.00ms ± 7.39ms +0.36%
bench_hydration/Turbopack RSC/1000 modules 2926.46ms ± 7.99ms 2920.13ms ± 5.05ms -0.22%
bench_hydration/Turbopack SSR/1000 modules 2721.55ms ± 6.89ms 2717.61ms ± 9.30ms -0.14%
bench_startup/Turbopack CSR/1000 modules 1689.34ms ± 3.52ms 1676.48ms ± 3.75ms -0.76%
bench_startup/Turbopack RCC/1000 modules 2558.28ms ± 5.72ms 2559.99ms ± 7.26ms +0.07%
bench_startup/Turbopack RSC/1000 modules 2467.59ms ± 6.71ms 2470.11ms ± 7.31ms +0.10%
bench_startup/Turbopack SSR/1000 modules 2088.14ms ± 5.05ms 2098.42ms ± 4.05ms +0.49%

@github-actions
Copy link
Contributor

🟢 CI successful 🟢

Thanks

@sokra sokra merged commit 8c6f07a into main Jan 13, 2023
@sokra sokra deleted the alexkirsz/web-423-add-a-basic-test-for-nextdynamic branch January 13, 2023 15:40
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@alexkirsz
Add basic test for next/dynamic (vercel/turbo#3307)
e3f4c2f 
This adds two basic tests for next/dynamic:
* one ensures that SSR supports dynamic components;
* the other ensures that SSR doesn't run when `ssr: false`.
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@alexkirsz
Add basic test for next/dynamic (vercel/turbo#3307)
ac8fa68 
This adds two basic tests for next/dynamic:
* one ensures that SSR supports dynamic components;
* the other ensures that SSR doesn't run when `ssr: false`.
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexkirsz @sokra