fix error overlay sometimes now showing #3331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
ForsakenHarmony
commented
Jan 16, 2023
| @@ -116,6 +116,15 @@ function aggregateUpdates( | |||
| const key = resourceKey(msg.resource); | |||
| const aggregated = chunksWithUpdates.get(key); | |||
|
|
|||
| if (msg.type === "issues" && aggregated == null && hasIssues) { | |||
| // add an empty record to make sure we don't call `onBuildOk` | |||
| chunksWithUpdates.set(key, { | |||
There was a problem hiding this comment.
We check if there are entries in the map below, so even if we have no updates we insert an empty record to make sure it doesn't think everything is fine
ForsakenHarmony
force-pushed
the
hrmny/web-419-fallback-error-overlay-not-shown
branch
from
617c184
to
f95e796
Compare
Benchmark for b9943daClick to view benchmark
|
🟢 CI successful 🟢Thanks |
jridgewell
approved these changes
Jan 17, 2023
| @@ -116,6 +116,15 @@ function aggregateUpdates( | |||
| const key = resourceKey(msg.resource); | |||
| const aggregated = chunksWithUpdates.get(key); | |||
|
|
|||
| if (msg.type === "issues" && aggregated == null && hasIssues) { | |||
There was a problem hiding this comment.
Nit: Looks like this can be merged with the if statements below?
There was a problem hiding this comment.
could be, but imo makes it harder to read
|
Any chance this fixes WEB-439? |
ForsakenHarmony
deleted the
hrmny/web-419-fallback-error-overlay-not-shown
branch
|
@wbinnssmith it might |
This was referenced Jan 20, 2023
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.