Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add full next.js config #3343

Merged
merged 2 commits into from
Jan 19, 2023
Merged

add full next.js config #3343

merged 2 commits into from
Jan 19, 2023

Conversation

ForsakenHarmony
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2023 •
edited

🟢 CI successful 🟢

Thanks

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/full-next-config branch 2 times, most recently from 38923e5 to 33b5564 Compare January 18, 2023 14:56
@ForsakenHarmony
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ForsakenHarmony ForsakenHarmony mentioned this pull request Jan 18, 2023
Merged
@ForsakenHarmony ForsakenHarmony marked this pull request as ready for review January 19, 2023 19:14
@ForsakenHarmony ForsakenHarmony requested review from a team as code owners January 19, 2023 19:14
@vercel vercel deleted a comment from github-actions bot Jan 19, 2023
@vercel vercel deleted a comment from vercel bot Jan 19, 2023
@vercel vercel deleted a comment from github-actions bot Jan 19, 2023
@vercel vercel deleted a comment from github-actions bot Jan 19, 2023
mehulkar
mehulkar approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@mehulkar mehulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cargo.toml changes look good to me!

@vercel
Copy link

vercel bot commented Jan 19, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-basic-web 🔄 Building (Inspect) Jan 19, 2023 at 7:32PM (UTC)
examples-svelte-web 🔄 Building (Inspect) Jan 19, 2023 at 7:32PM (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 19, 2023 at 7:32PM (UTC)
7 Ignored Deployments
Name Status Preview Comments Updated
examples-cra-web ⬜️ Ignored (Inspect) Jan 19, 2023 at 7:32PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Jan 19, 2023 at 7:32PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jan 19, 2023 at 7:32PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Jan 19, 2023 at 7:32PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 19, 2023 at 7:32PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Jan 19, 2023 at 7:32PM (UTC)
turbo-vite-web ⬜️ Ignored (Inspect) Jan 19, 2023 at 7:32PM (UTC)

@github-actions
Copy link
Contributor

Benchmark for 5b17514

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8267.07µs ± 58.56µs 8308.97µs ± 37.56µs +0.51%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8633.55µs ± 110.39µs 8610.06µs ± 57.32µs -0.27%
bench_hmr_to_commit/Turbopack RSC/1000 modules 476.98ms ± 2.68ms 484.96ms ± 3.15ms +1.67%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8510.52µs ± 80.21µs 8521.46µs ± 73.98µs +0.13%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7386.36µs ± 71.73µs 7375.75µs ± 55.42µs -0.14%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7584.48µs ± 75.13µs 7517.96µs ± 54.67µs -0.88%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7523.06µs ± 58.34µs 7415.82µs ± 72.28µs -1.43%
bench_hydration/Turbopack RCC/1000 modules 3488.65ms ± 8.89ms 3479.08ms ± 14.33ms -0.27%
bench_hydration/Turbopack RSC/1000 modules 2971.72ms ± 9.86ms 2985.52ms ± 5.61ms +0.46%
bench_hydration/Turbopack SSR/1000 modules 2797.26ms ± 16.18ms 2788.19ms ± 13.39ms -0.32%
bench_startup/Turbopack CSR/1000 modules 1715.02ms ± 5.12ms 1711.82ms ± 4.86ms -0.19%
bench_startup/Turbopack RCC/1000 modules 2631.47ms ± 10.90ms 2644.97ms ± 16.51ms +0.51%
bench_startup/Turbopack RSC/1000 modules 2502.29ms ± 9.32ms 2493.60ms ± 11.60ms -0.35%
bench_startup/Turbopack SSR/1000 modules 2162.16ms ± 7.43ms 2155.95ms ± 8.37ms -0.29%

@ForsakenHarmony ForsakenHarmony merged commit ee5f903 into main Jan 19, 2023
@ForsakenHarmony ForsakenHarmony deleted the hrmny/full-next-config branch January 19, 2023 20:54
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@ForsakenHarmony
add full next.js config (vercel/turbo#3343)
341bab9
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@ForsakenHarmony
add full next.js config (vercel/turbo#3343)
1d3e782
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehulkar mehulkar mehulkar approved these changes

@wbinnssmith wbinnssmith wbinnssmith approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ForsakenHarmony @mehulkar @wbinnssmith