Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent injecting non js files in app renderer #3399

Merged
merged 1 commit into from Jan 20, 2023
Merged

prevent injecting non js files in app renderer #3399

merged 1 commit into from Jan 20, 2023

Conversation

ForsakenHarmony
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Jan 20, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-native-web 🔄 Building (Inspect) Jan 20, 2023 at 6:53PM (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 6:53PM (UTC)
8 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Jan 20, 2023 at 6:53PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Jan 20, 2023 at 6:53PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Jan 20, 2023 at 6:53PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jan 20, 2023 at 6:53PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 20, 2023 at 6:53PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Jan 20, 2023 at 6:53PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Jan 20, 2023 at 6:53PM (UTC)
turbo-vite-web ⬜️ Ignored (Inspect) Jan 20, 2023 at 6:53PM (UTC)

@ForsakenHarmony ForsakenHarmony marked this pull request as ready for review January 20, 2023 18:52
@ForsakenHarmony ForsakenHarmony requested a review from a team as a code owner January 20, 2023 18:52
@ForsakenHarmony
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ForsakenHarmony ForsakenHarmony enabled auto-merge (squash) January 20, 2023 19:06
@github-actions
Copy link
Contributor

Benchmark for fdbe888

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8808.44µs ± 63.15µs 8752.29µs ± 84.10µs -0.64%
bench_hmr_to_commit/Turbopack RCC/1000 modules 9052.01µs ± 62.55µs 9015.56µs ± 55.60µs -0.40%
bench_hmr_to_commit/Turbopack RSC/1000 modules 454.62ms ± 3.86ms 451.83ms ± 2.13ms -0.62%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8802.39µs ± 77.10µs 8973.15µs ± 176.13µs +1.94%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7779.93µs ± 64.43µs 7738.90µs ± 95.34µs -0.53%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7858.33µs ± 59.64µs 7846.98µs ± 80.61µs -0.14%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7753.13µs ± 67.03µs 7792.48µs ± 72.84µs +0.51%
bench_hydration/Turbopack RCC/1000 modules 3387.12ms ± 14.45ms 3387.90ms ± 8.50ms +0.02%
bench_hydration/Turbopack RSC/1000 modules 2842.80ms ± 8.45ms 2830.34ms ± 9.55ms -0.44%
bench_hydration/Turbopack SSR/1000 modules 2631.10ms ± 7.16ms 2636.07ms ± 6.78ms +0.19%
bench_startup/Turbopack CSR/1000 modules 1626.38ms ± 4.34ms 1625.41ms ± 7.15ms -0.06%
bench_startup/Turbopack RCC/1000 modules 2509.86ms ± 9.38ms 2483.18ms ± 9.40ms -1.06%
bench_startup/Turbopack RSC/1000 modules 2399.48ms ± 6.71ms 2377.51ms ± 7.87ms -0.92%
bench_startup/Turbopack SSR/1000 modules 2061.60ms ± 6.39ms 2060.64ms ± 4.61ms -0.05%

@github-actions
Copy link
Contributor

🟢 CI successful 🟢

Thanks

@ForsakenHarmony ForsakenHarmony merged commit 583e75f into main Jan 20, 2023
@ForsakenHarmony ForsakenHarmony deleted the hrmny/web-346-app-renderer-injects-sourcemaps branch January 20, 2023 20:11
@Brooooooklyn Brooooooklyn mentioned this pull request Jan 21, 2023
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Jan 21, 2023
@Brooooooklyn
build(cargo): update turbopack (#45126)
53be72b 
### Features
- vercel/turbo#3409

### Bug Fixes
- vercel/turbo#3399
- vercel/turbo#3412

### Chore
- vercel/turbo#3398
- vercel/turbo#3391
- vercel/turbo#3350
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@ForsakenHarmony
prevent injecting non js files in app renderer (vercel/turbo#3399)
8e202bb
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@ForsakenHarmony
prevent injecting non js files in app renderer (vercel/turbo#3399)
f3501d9
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ForsakenHarmony @sokra