docs(language): removes "simply" to be more inclusive #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to be selective in which instances of just remain.
one more good replacement
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/5B7r3pe2KV3sSo43s5RXLVT7zgiQ |
|
Agreed. Great PR |
jaredpalmer
approved these changes
Dec 17, 2021
jaredpalmer
added
the
pr: automerge
sokra
pushed a commit
that referenced
this pull request
Oct 25, 2022
- Removes the transform of `trait TraitName: TraitDep` into `trait TraitName: Into<TraitDep>` - Removes the generated `lazy_static!` (was always a bit hard to read in the macro expansion, and `once_cell::Lazy` does the same without a macro) - Generates unique names for all `impl`s, before implementing 2 traits with the same function name would lead to a compile error because they got the same func ident
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hello!
As a maintainer of a 28 package monorepo, turborepo is a very interesting thing for my team to try out. Thanks for this (and @jaredpalmer for tsdx too)
In reading the documentation today, I bristled at a few places where the language assumed knowledge or trivialized a step that might be new to someone.
If this goes against a writing guide or established tone I am unaware of, feel free to carry on!
References:
Just by Brad Frost
Google Developer Docs