port(turbo): Link #3500
Merged
port(turbo): Link #3500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@NicholasLYang is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
area: ci
area: examples
NicholasLYang
force-pushed
the
nicholasyang/link
branch
3 times, most recently
from
34a4a34
to
7ee983d
Compare
NicholasLYang
force-pushed
the
nicholasyang/link
branch
from
7ee983d
to
79d9b7a
Compare
chris-olszewski
requested changes
Jan 28, 2023
to initialize one and only one copy of each config struct.
- Removed Go code for link - Print on error to match Go
Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com>
chris-olszewski
approved these changes
Jan 30, 2023
| @@ -13,27 +13,38 @@ pub trait UserClient { | |||
| fn set_token(&mut self, token: String); | |||
| async fn get_user(&self) -> Result<UserResponse>; | |||
| async fn get_teams(&self) -> Result<TeamsResponse>; | |||
| async fn get_caching_status(&self, team_id: &str) -> Result<CachingStatus>; | |||
| async fn get_caching_status(&self, team_id: &str) -> Result<CachingStatusResponse>; | |||
There was a problem hiding this comment.
Is it important that it returns the structure of the response and not just the data from the trait? e.g. returning CachingStatus vs CachingStatusResponse
There was a problem hiding this comment.
It's not particularly important. At some point we might add pagination, at which point the response type will have more importance.
|
|
||
| if !gitignore_path.exists() { | ||
| let mut gitignore = File::create(gitignore_path)?; | ||
| #[cfg(unix)] |
There was a problem hiding this comment.
Should we include setting the permissions on macos as well?
There was a problem hiding this comment.
Isn't macOS also unix?
mehulkar
pushed a commit
that referenced
this pull request
Feb 1, 2023
Ported `link`. Required porting more `APIClient` functionality --------- Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported
link. Required porting moreAPIClientfunctionality