Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return a 404 status code when a data route is .notFound #3545

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Return a 404 status code when a data route is .notFound #3545

merged 2 commits into from
Jan 31, 2023

Conversation

alexkirsz
Copy link
Contributor

@alexkirsz alexkirsz commented Jan 31, 2023 •
edited

Returning a 404 status code is required for the client-side router to redirect to the error page.

@alexkirsz alexkirsz requested a review from a team as a code owner January 31, 2023 15:33
@vercel
Copy link

vercel bot commented Jan 31, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

10 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Jan 31, 2023 at 3:34PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Jan 31, 2023 at 3:34PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Jan 31, 2023 at 3:34PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jan 31, 2023 at 3:34PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Jan 31, 2023 at 3:34PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 31, 2023 at 3:34PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Jan 31, 2023 at 3:34PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Jan 31, 2023 at 3:34PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Jan 31, 2023 at 3:34PM (UTC)
turbo-site ⬜️ Ignored (Inspect) Jan 31, 2023 at 3:34PM (UTC)

@github-actions
Copy link
Contributor

Benchmark for 488949a

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack RSC/1000 modules 493.47ms ± 1.85ms 486.75ms ± 0.88ms -1.36% -0.26%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9152.27µs ± 103.47µs 9134.42µs ± 66.22µs -0.19%
bench_hmr_to_commit/Turbopack RCC/1000 modules 9393.72µs ± 103.43µs 9482.36µs ± 75.46µs +0.94%
bench_hmr_to_commit/Turbopack RSC/1000 modules 493.47ms ± 1.85ms 486.75ms ± 0.88ms -1.36% -0.26%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9245.32µs ± 85.58µs 9329.51µs ± 102.83µs +0.91%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8165.75µs ± 72.95µs 8318.66µs ± 55.75µs +1.87%
bench_hmr_to_eval/Turbopack RCC/1000 modules 8351.66µs ± 99.85µs 8341.33µs ± 64.83µs -0.12%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8405.55µs ± 83.38µs 8488.22µs ± 121.37µs +0.98%
bench_hydration/Turbopack RCC/1000 modules 3747.86ms ± 9.21ms 3787.20ms ± 13.35ms +1.05%
bench_hydration/Turbopack RSC/1000 modules 3260.86ms ± 15.13ms 3234.36ms ± 11.82ms -0.81%
bench_hydration/Turbopack SSR/1000 modules 3005.34ms ± 8.72ms 3014.27ms ± 9.70ms +0.30%
bench_startup/Turbopack CSR/1000 modules 2081.10ms ± 14.59ms 2063.63ms ± 14.29ms -0.84%
bench_startup/Turbopack RCC/1000 modules 2448.27ms ± 6.24ms 2446.11ms ± 5.48ms -0.09%
bench_startup/Turbopack RSC/1000 modules 2361.25ms ± 4.64ms 2367.55ms ± 7.38ms +0.27%
bench_startup/Turbopack SSR/1000 modules 2013.31ms ± 4.83ms 2019.20ms ± 4.03ms +0.29%

@alexkirsz alexkirsz merged commit 7b4cf1e into main Jan 31, 2023
@alexkirsz alexkirsz deleted the alexkirsz/web-448-handle-404-pages branch January 31, 2023 16:43
@github-actions
Copy link
Contributor

🟢 CI successful 🟢

Thanks

@Brooooooklyn Brooooooklyn mentioned this pull request Jan 31, 2023
Merged
shuding pushed a commit to vercel/next.js that referenced this pull request Feb 1, 2023
@Brooooooklyn
build(cargo): update turbopack to turbopack-230201.1 (#45454)
221692b 
### Features
- vercel/turbo#3514
- vercel/turbo#3530
- vercel/turbo#3510
- vercel/turbo#3497

### Bug fixes
- vercel/turbo#3545
- vercel/turbo#3522
- vercel/turbo#3525
- vercel/turbo#3518
- vercel/turbo#3501
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@alexkirsz
Return a 404 status code when a data route is .notFound (vercel/tur…
79b7ff8 
…bo#3545)

Returning a 404 status code is required for the client-side router to
redirect to the error page.
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@alexkirsz
Return a 404 status code when a data route is .notFound (vercel/tur…
779bb9e 
…bo#3545)

Returning a 404 status code is required for the client-side router to
redirect to the error page.
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexkirsz @ForsakenHarmony