-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(turborepo): Check for TLS feature at build-time #3585
fix(turborepo): Check for TLS feature at build-time #3585
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
@NicholasLYang is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
@@ -405,7 +405,7 @@ jobs: | |||
uses: actions-rs/cargo@v1 | |||
with: | |||
command: check | |||
args: --workspace --all-targets --locked | |||
args: --workspace --all-targets --locked --features rustls-tls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could make it a default feature, so it doesn't require passing the feature to every command:
turbo/crates/next-dev/Cargo.toml
Line 27 in b1d013a
default = ["cli", "custom_allocator", "native-tls"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately we can't: #3582 (review)
93b41b4
to
991f475
Compare
No description provided.