Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Increase sidebar text contrast in dark mode #3625

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

wbinnssmith
Copy link
Member

This increases the contrast of the sidebar text against its dark background by slightly lightening it. It now passes WCAG AA guidelines.

Test Plan: https://webaim.org/resources/contrastchecker/

@vercel
Copy link

vercel bot commented Feb 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 3, 2023 at 5:26PM (UTC)
9 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 5:26PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 5:26PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 3, 2023 at 5:26PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 3, 2023 at 5:26PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 5:26PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 3, 2023 at 5:26PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 5:26PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 5:26PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 5:26PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

🟢 CI successful 🟢

Thanks

Copy link
Contributor

@arlyon arlyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to avoid forking the theme. Much more readable :)

@wbinnssmith wbinnssmith merged commit 3271bc6 into main Feb 6, 2023
@wbinnssmith wbinnssmith deleted the wbinnssmith/docs-text-contrast branch February 6, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation area: site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants